lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Tue, 24 Nov 2015 15:29:10 -0800
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Martyn Welch <martyn@...chs.me.uk>
Cc:	Egor Uleyskiy <egor.ulieiskii@...il.com>,
	Manohar Vanga <manohar.vanga@...il.com>,
	Trivial Patch Monkey <trivial@...nel.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers: staging: vme: Fixed code style issues

On Fri, Nov 13, 2015 at 11:04:08PM +0000, Martyn Welch wrote:
> 
> 
> On 13/11/15 20:01, Egor Uleyskiy wrote:
> >From: Egor Uleyskiy <egor.ulieiskii@...il.com>
> >
> >* Fixed indention
> >* Deleted extra empty lines
> >* Constructions that looks like
> >     card = kzalloc(sizeof(struct pio2_card), GFP_KERNEL);
> >   are changed to
> >     card = kzalloc(sizeof(*card), GFP_KERNEL);
> Also:
> 
>  * Removing extra bracketing from uses of the address operator
>  * Use preferred null return check style

Ick, not good, please break this up into individual patches,
one-per-type-of-fix.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ