linux-kernel - Re: [PATCH v12 01/30] tracing: Update cond flag when enabling or disabling a trigger

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 25 Nov 2015 10:27:45 +0900
From:	Namhyung Kim <namhyung@...nel.org>
To:	Steven Rostedt <rostedt@...dmis.org>
CC:	Tom Zanussi <tom.zanussi@...ux.intel.com>,
	daniel.wagner@...-carit.de, masami.hiramatsu.pt@...achi.com,
	josh@...htriplett.org, andi@...stfloor.org,
	mathieu.desnoyers@...icios.com, peterz@...radead.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v12 01/30] tracing: Update cond flag when enabling or
 disabling a trigger

Hi Steve and Tom,

On Mon, Nov 23, 2015 at 04:29:43PM -0500, Steven Rostedt wrote:
> On Mon, 23 Nov 2015 13:51:16 -0600
> Tom Zanussi <tom.zanussi@...ux.intel.com> wrote:
> 
> > When a trigger is enabled, the cond flag should be set beforehand,
> > otherwise a trigger that's expecting to process a trace record
> > (e.g. one with post_trigger set) could be invoked without one.
> > 
> > Likewise a trigger's cond flag should be reset after it's disabled,
> > not before.
> > 
> > Signed-off-by: Tom Zanussi <tom.zanussi@...ux.intel.com>
> > Signed-off-by: Daniel Wagner <daniel.wagner@...-carit.de>
> > Reviewed-by: Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>
> > Tested-by: Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>
> > ---
> 
> FYI, I've applied this patch as it looks like something that should be
> added regardless of the rest of the series.

You can add my Reviewed-by if you want.  I'll try to review others soon.

Thanks,
Namhyung
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/