linux-kernel - Re: [PATCH v5 1/5] Implement an ioctl to support the USMTMC-USB488 READ_STATUS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 28 Nov 2015 16:57:47 +0200
From:	Andy Shevchenko <andy.shevchenko@...il.com>
To:	Dave Penkler <dpenkler@...il.com>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	peter.chen@...escale.com, teuniz@...il.com,
	USB <linux-usb@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v5 1/5] Implement an ioctl to support the USMTMC-USB488
 READ_STATUS_BYTE operation.

On Sat, Nov 28, 2015 at 1:55 PM, Dave Penkler <dpenkler@...il.com> wrote:
> On Wed, Nov 25, 2015 at 10:38:39PM +0200, Andy Shevchenko wrote:
>> On Wed, Nov 25, 2015 at 11:18 AM, Dave Penkler <dpenkler@...il.com> wrote:
>> > On Sun, Nov 22, 2015 at 12:32:41PM +0200, Andy Shevchenko wrote:
>> >> On Sun, Nov 22, 2015 at 11:19 AM, Dave Penkler <dpenkler@...il.com> wrote:
>> >> > On Wed, Nov 18, 2015 at 11:55:27AM +0200, Andy Shevchenko wrote:
>> >> >> On Wed, Nov 18, 2015 at 10:37 AM, Dave Penkler <dpenkler@...il.com> wrote:

Thank you for an update!

>> >> >> > +       switch (status) {
>> >> >> > +       case 0: /* SUCCESS */
>> >> >> > +               if (data->iin_buffer[0] & 0x80) {
>> >> >> > +                       /* check for valid STB notification */
>> >> >> > +                       if ((data->iin_buffer[0] & 0x7f) > 1) {

How can I miss that there are two conditionals in a sequence and
moreover for the same data?!
That might explain the optimization done by compiler.

So, could it be transformed to simple one condition
   if (data->iin_buffer[0] > 0x81 /* 129 */) {
?

-- 
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/