linux-kernel - Re: [alsa-devel] [PATCH 2/2] ASoC: pcm3168a: Add driver for pcm3168a codec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 1 Dec 2015 17:59:56 +0000
From:	Mark Brown <broonie@...nel.org>
To:	Damien Horsley <Damien.Horsley@...tec.com>
Cc:	alsa-devel@...a-project.org, Rob Herring <robh+dt@...nel.org>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Liam Girdwood <lgirdwood@...il.com>,
	Jaroslav Kysela <perex@...ex.cz>,
	Takashi Iwai <tiwai@...e.com>, Jyri Sarha <jsarha@...com>,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	James Hartley <james.hartley@...tec.com>
Subject: Re: [alsa-devel] [PATCH 2/2] ASoC: pcm3168a: Add driver for pcm3168a
 codec

On Mon, Nov 30, 2015 at 04:49:30PM +0000, Damien Horsley wrote:
> On 27/11/15 12:54, Mark Brown wrote:

> > Please try to keep your CC lists reasonable - only CC people who have an
> > interest in the patch you're posting.  The CC list you have here is far
> > too broad, I can't figure out why a lot of the people there ended up
> > there.  If you've got 10 people that's generally a warning sign.

> The list was generated by scripts/get_maintainer.pl when used on the
> patches. I will remove some that look like they don't need to be there.

You should not be using get_maintainer unfiltered, you need to think
about why everyone is there.  People often end up getting included due
to just random cleanups and getting lots of mail about drivers they have
no lasting interest in may be demotivating.

> > Being in right justified mode *does* have an effect - it changes where
> > the audio data starts relative to LRCLK.  It is true that if the frame
> > has exactly the right number of clocks left and right justified are
> > identical but extra clocks are in general permitted so it looks like
> > your right justified case above just isn't something the device really
> > supports.

> Should the value returned by snd_soc_params_to_frame_size be treated as
> the minimum frame size?

Yes, in general most hardware is perfectly happy with extra clocks.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)