linux-kernel - Re: [PATCH v2] Input: psmouse - rename ps2pp_init() to ps2pp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 3 Dec 2015 09:34:40 +0100
From:	Hans de Goede <hdegoede@...hat.com>
To:	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	linux-input@...r.kernel.org
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] Input: psmouse - rename ps2pp_init() to ps2pp_detect()

Hi,

On 02-12-15 20:25, Dmitry Torokhov wrote:
> This makes Logitech PS2++ protocol implementation consistent with
> the naming in other protocols. Also mark the stub as "static inline"
>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@...il.com>

Much better / less confusing then the old code :)

Reviewed-by: Hans de Goede <hdegoede@...hat.com>

Regards,

hans



> ---
>
> V2: add forgotten drivers/input/mouse/logips2pp.c file.
>
>   drivers/input/mouse/logips2pp.c    | 2 +-
>   drivers/input/mouse/logips2pp.h    | 4 ++--
>   drivers/input/mouse/psmouse-base.c | 2 +-
>   3 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/input/mouse/logips2pp.c b/drivers/input/mouse/logips2pp.c
> index 136e222..422da1c 100644
> --- a/drivers/input/mouse/logips2pp.c
> +++ b/drivers/input/mouse/logips2pp.c
> @@ -325,7 +325,7 @@ static void ps2pp_set_model_properties(struct psmouse *psmouse,
>    * that support it.
>    */
>
> -int ps2pp_init(struct psmouse *psmouse, bool set_properties)
> +int ps2pp_detect(struct psmouse *psmouse, bool set_properties)
>   {
>   	struct ps2dev *ps2dev = &psmouse->ps2dev;
>   	unsigned char param[4];
> diff --git a/drivers/input/mouse/logips2pp.h b/drivers/input/mouse/logips2pp.h
> index 0c186f0..bf62945 100644
> --- a/drivers/input/mouse/logips2pp.h
> +++ b/drivers/input/mouse/logips2pp.h
> @@ -12,9 +12,9 @@
>   #define _LOGIPS2PP_H
>
>   #ifdef CONFIG_MOUSE_PS2_LOGIPS2PP
> -int ps2pp_init(struct psmouse *psmouse, bool set_properties);
> +int ps2pp_detect(struct psmouse *psmouse, bool set_properties);
>   #else
> -inline int ps2pp_init(struct psmouse *psmouse, bool set_properties)
> +static inline int ps2pp_detect(struct psmouse *psmouse, bool set_properties)
>   {
>   	return -ENOSYS;
>   }
> diff --git a/drivers/input/mouse/psmouse-base.c b/drivers/input/mouse/psmouse-base.c
> index e909c6e..90d9218 100644
> --- a/drivers/input/mouse/psmouse-base.c
> +++ b/drivers/input/mouse/psmouse-base.c
> @@ -699,7 +699,7 @@ static const struct psmouse_protocol psmouse_protocols[] = {
>   		.type		= PSMOUSE_PS2PP,
>   		.name		= "PS2++",
>   		.alias		= "logitech",
> -		.detect		= ps2pp_init,
> +		.detect		= ps2pp_detect,
>   	},
>   #endif
>   	{
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/