linux-kernel - Re: [PATCH] leds: sunfire: Use platform_register/unregister

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 03 Dec 2015 11:43:41 +0100
From:	Jacek Anaszewski <j.anaszewski@...sung.com>
To:	Thierry Reding <thierry.reding@...il.com>
Cc:	linux-leds@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] leds: sunfire: Use platform_register/unregister_drivers()

On 12/02/2015 05:27 PM, Thierry Reding wrote:
> From: Thierry Reding <treding@...dia.com>
>
> These new helpers simplify implementing multi-driver modules and
> properly handle failure to register one driver by unregistering all
> previously registered drivers.
>
> Signed-off-by: Thierry Reding <treding@...dia.com>
> ---
>   drivers/leds/leds-sunfire.c | 23 +++++++----------------
>   1 file changed, 7 insertions(+), 16 deletions(-)
>
> diff --git a/drivers/leds/leds-sunfire.c b/drivers/leds/leds-sunfire.c
> index c2553c54f2cf..7c09db8bd4e8 100644
> --- a/drivers/leds/leds-sunfire.c
> +++ b/drivers/leds/leds-sunfire.c
> @@ -234,28 +234,19 @@ static struct platform_driver sunfire_fhc_led_driver = {
>   	},
>   };
>
> +static struct platform_driver * const drivers[] = {
> +	&sunfire_clockboard_led_driver,
> +	&sunfire_fhc_led_driver,
> +};
> +
>   static int __init sunfire_leds_init(void)
>   {
> -	int err = platform_driver_register(&sunfire_clockboard_led_driver);
> -
> -	if (err) {
> -		pr_err("Could not register clock board LED driver\n");
> -		return err;
> -	}
> -
> -	err = platform_driver_register(&sunfire_fhc_led_driver);
> -	if (err) {
> -		pr_err("Could not register FHC LED driver\n");
> -		platform_driver_unregister(&sunfire_clockboard_led_driver);
> -	}
> -
> -	return err;
> +	return platform_register_drivers(drivers, ARRAY_SIZE(drivers));
>   }
>
>   static void __exit sunfire_leds_exit(void)
>   {
> -	platform_driver_unregister(&sunfire_clockboard_led_driver);
> -	platform_driver_unregister(&sunfire_fhc_led_driver);
> +	platform_unregister_drivers(drivers, ARRAY_SIZE(drivers));
>   }
>
>   module_init(sunfire_leds_init);
>

Applied, thanks.

-- 
Best Regards,
Jacek Anaszewski
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/