linux-kernel - Re: [PATCH V7 1/1] usb:serial: Add Fintek F81532/534 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Sun, 6 Dec 2015 07:28:20 +0800
From:	kbuild test robot <lkp@...el.com>
To:	Peter Hung <hpeter@...il.com>
Cc:	kbuild-all@...org, johan@...nel.org, gregkh@...uxfoundation.org,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
	tom_tsai@...tek.com.tw, peter_hong@...tek.com.tw,
	Peter Hung <hpeter+linux_kernel@...il.com>
Subject: Re: [PATCH V7 1/1] usb:serial: Add Fintek F81532/534 driver

Hi Peter,

[auto build test ERROR on usb/usb-testing]
[also build test ERROR on v4.4-rc3 next-20151203]

url:    https://github.com/0day-ci/linux/commits/Peter-Hung/usb-serial-Add-Fintek-F81532-534-driver/20151202-152239
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
config: mips-allmodconfig (attached as .config)
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=mips 

All errors (new ones prefixed by >>):

   drivers/usb/serial/f81534.c:514:1: warning: data definition has no type or storage class
    MODULE_DEVICE_TABLE(usb, id_table);
    ^
>> drivers/usb/serial/f81534.c:514:1: error: type defaults to 'int' in declaration of 'MODULE_DEVICE_TABLE' [-Werror=implicit-int]
   drivers/usb/serial/f81534.c:514:1: warning: parameter names (without types) in function declaration
   In file included from drivers/usb/serial/f81534.c:103:0:
   include/linux/usb/serial.h:403:1: warning: data definition has no type or storage class
    module_init(usb_serial_module_init);     \
    ^
   include/linux/usb/serial.h:411:2: note: in expansion of macro 'usb_serial_module_driver'
     usb_serial_module_driver(KBUILD_MODNAME, __serial_drivers, __ids)
     ^
   drivers/usb/serial/f81534.c:2940:1: note: in expansion of macro 'module_usb_serial_driver'
    module_usb_serial_driver(serial_drivers, id_table);
    ^
>> include/linux/usb/serial.h:403:1: error: type defaults to 'int' in declaration of 'module_init' [-Werror=implicit-int]
    module_init(usb_serial_module_init);     \
    ^
   include/linux/usb/serial.h:411:2: note: in expansion of macro 'usb_serial_module_driver'
     usb_serial_module_driver(KBUILD_MODNAME, __serial_drivers, __ids)
     ^
   drivers/usb/serial/f81534.c:2940:1: note: in expansion of macro 'module_usb_serial_driver'
    module_usb_serial_driver(serial_drivers, id_table);
    ^
   drivers/usb/serial/f81534.c:2940:1: warning: parameter names (without types) in function declaration
   In file included from drivers/usb/serial/f81534.c:103:0:
   include/linux/usb/serial.h:408:1: warning: data definition has no type or storage class
    module_exit(usb_serial_module_exit);
    ^
   include/linux/usb/serial.h:411:2: note: in expansion of macro 'usb_serial_module_driver'
     usb_serial_module_driver(KBUILD_MODNAME, __serial_drivers, __ids)
     ^
   drivers/usb/serial/f81534.c:2940:1: note: in expansion of macro 'module_usb_serial_driver'
    module_usb_serial_driver(serial_drivers, id_table);
    ^
>> include/linux/usb/serial.h:408:1: error: type defaults to 'int' in declaration of 'module_exit' [-Werror=implicit-int]
    module_exit(usb_serial_module_exit);
    ^
   include/linux/usb/serial.h:411:2: note: in expansion of macro 'usb_serial_module_driver'
     usb_serial_module_driver(KBUILD_MODNAME, __serial_drivers, __ids)
     ^
   drivers/usb/serial/f81534.c:2940:1: note: in expansion of macro 'module_usb_serial_driver'
    module_usb_serial_driver(serial_drivers, id_table);
    ^
   drivers/usb/serial/f81534.c:2940:1: warning: parameter names (without types) in function declaration
>> drivers/usb/serial/f81534.c:154:2: error: expected declaration specifiers or '...' before string constant
     "Fintek USB to Serial Ports Driver (F81532/F81534-Evaluation Board)"
     ^
   drivers/usb/serial/f81534.c:2942:20: note: in expansion of macro 'DRIVER_DESC'
    MODULE_DESCRIPTION(DRIVER_DESC);
                       ^
   drivers/usb/serial/f81534.c:2943:15: error: expected declaration specifiers or '...' before string constant
    MODULE_AUTHOR("Peter Hong <Peter_Hong@...tek.com.tw>");
                  ^
   drivers/usb/serial/f81534.c:2944:15: error: expected declaration specifiers or '...' before string constant
    MODULE_AUTHOR("Tom Tsai <Tom_Tsai@...tek.com.tw>");
                  ^
   drivers/usb/serial/f81534.c:2945:16: error: expected declaration specifiers or '...' before string constant
    MODULE_LICENSE("GPL");
                   ^
   In file included from drivers/usb/serial/f81534.c:103:0:
   include/linux/usb/serial.h:398:19: warning: 'usb_serial_module_init' defined but not used [-Wunused-function]
    static int __init usb_serial_module_init(void)    \
                      ^
   include/linux/usb/serial.h:411:2: note: in expansion of macro 'usb_serial_module_driver'
     usb_serial_module_driver(KBUILD_MODNAME, __serial_drivers, __ids)
     ^
   drivers/usb/serial/f81534.c:2940:1: note: in expansion of macro 'module_usb_serial_driver'
    module_usb_serial_driver(serial_drivers, id_table);
    ^
   include/linux/usb/serial.h:404:20: warning: 'usb_serial_module_exit' defined but not used [-Wunused-function]
    static void __exit usb_serial_module_exit(void)    \
                       ^
   include/linux/usb/serial.h:411:2: note: in expansion of macro 'usb_serial_module_driver'
     usb_serial_module_driver(KBUILD_MODNAME, __serial_drivers, __ids)
     ^
   drivers/usb/serial/f81534.c:2940:1: note: in expansion of macro 'module_usb_serial_driver'
    module_usb_serial_driver(serial_drivers, id_table);
    ^
   cc1: some warnings being treated as errors

vim +514 drivers/usb/serial/f81534.c

   508	static const struct usb_device_id id_table[] = {
   509		{USB_DEVICE(FINTEK_VENDOR_ID_1, FINTEK_DEVICE_ID)},
   510		{USB_DEVICE(FINTEK_VENDOR_ID_2, FINTEK_DEVICE_ID)},
   511		{}			/* Terminating entry */
   512	};
   513	
 > 514	MODULE_DEVICE_TABLE(usb, id_table);
   515	
   516	struct f81534_serial_private {
   517		bool is_phy_port_not_empty[F81534_NUM_PORT];

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/octet-stream" (39731 bytes)