| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Sun, 6 Dec 2015 17:36:50 +0100 From: Johan Hovold <johan@...nel.org> To: Konstantin Shkolnyy <konstantin.shkolnyy@...il.com> Cc: johan@...nel.org, linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] USB: serial: cp210x: Cleaned up USB access functions. On Mon, Nov 30, 2015 at 04:50:38PM -0600, Konstantin Shkolnyy wrote: > cp210x_get_config and cp210x_set_config were hard to use. They required > the buffer as an array of 32-bit values even for smaller values, and did > endian conversions on per-32-bit value basis, which is wrong for some > cp210x data structures (although not for any that were actually used.) > This change introduces separate register accessor functions for single > 8, 16 and 32-bit values, with endian conversion, as well as "block" > access functions without conversion. > > Signed-off-by: Konstantin Shkolnyy <konstantin.shkolnyy@...il.com> > --- > drivers/usb/serial/cp210x.c | 314 ++++++++++++++++++++++++++------------------ > 1 file changed, 186 insertions(+), 128 deletions(-) There's a bit too much going on here at once. Please split this into multiple patches to facilitate review (e.g. separate get and set, and possibly also the three widths). Thanks, Johan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists