linux-kernel - Re: [PATCH 00/13] perf tools: Move perf subcommand framework into lib/tools

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 6 Dec 2015 15:28:18 -0300
From:	Arnaldo Carvalho de Melo <acme@...nel.org>
To:	Ingo Molnar <mingo@...nel.org>
Cc:	Josh Poimboeuf <jpoimboe@...hat.com>, Jiri Olsa <jolsa@...hat.com>,
	Namhyung Kim <namhyung@...nel.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Ingo Molnar <mingo@...hat.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 00/13] perf tools: Move perf subcommand framework into
 lib/tools

Em Sun, Dec 06, 2015 at 10:37:52AM +0100, Ingo Molnar escreveu:
> 
> * Josh Poimboeuf <jpoimboe@...hat.com> wrote:
> 
> > Ingo suggested that I factor out the perf subcommand functionality
> > (originally copied from git) into tools/lib so that it can be used by
> > stacktool[*] and possibly others.
> > 
> > All the subcommand option handling files have been moved into libapi,
> > including parse-options.c, run-command.c, exec_cmd.c, help.c, usage.c,
> > and their dependencies.  Since several of the dependencies are more
> > general-purpose "utilities" which aren't directly related to
> > subcommands, I put everything in 'tools/lib/api/util'.  They're linked
> > into perf as part of the libapi.a library.
> > 
> > Patches 1-10 do some cleanups and splitting up of the code in
> > preparation for the move.
> > 
> > Patch 11 does the actual moving of the files into tools/lib/api/util.
> > 
> > [*] https://lkml.kernel.org/r/cover.1445443144.git.jpoimboe@redhat.com
> > 
> > Josh Poimboeuf (13):
> >   perf: Use -iquote for local include paths
> >   perf: Split up util.h
> >   perf: Move term functions out of util.c
> >   perf: Remove unused pager_use_color variable
> >   perf: Split up cache.h
> >   perf: Remove cache.h
> >   perf: Save cmdline arguments earlier
> >   perf: Remove check for unused PERF_PAGER_IN_USE
> >   perf: Move cmd_version() to builtin-version.c
> >   perf: Move help_unknown_cmd() to its own file
> >   perf tools: Move strlcpy() to tools/lib/string.c
> >   perf tools: Move perf subcommand framework into a library
> >   perf tools: Move subcommand framework and related utils to libapi
> 
> >  133 files changed, 852 insertions(+), 761 deletions(-)
> 
> So this split-out looks great to me!

I briefly looked at it on the smartphone, what I can remember as an
issue was naming, i.e. IIRC there is a util_cfg struct that looks too
vague, I'll re-read and suggest something.
 
> A bit of a background: this series is a necessary precondition of me being able to 
> merge 'stacktool' and the frame pointer handling enhancements Josh is working on - 
> but it would be nice if this could all be done via Arnaldo's perf tree to minimize 
> any impact on pending perf work.
 
> I've Cc:-ed Namhyung and Jiri as well, who've done a lot of work in perf/util/.

Commens from them would be more than welcome, Acks, even more.

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/