linux-kernel - Re: [PATCH] hexdump: Add ability to do endian conversions in print_hex

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 09 Dec 2015 15:15:20 -0800
From:	Joe Perches <joe@...ches.com>
To:	Andy Shevchenko <andy.shevchenko@...il.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Rasmus Villemoes <linux@...musvillemoes.dk>,
	Rob Herring <robh+dt@...nel.org>
Subject: Re: [PATCH] hexdump: Add ability to do endian conversions in
 print_hex_dump functions

On Thu, 2015-12-10 at 01:09 +0200, Andy Shevchenko wrote:
> On Thu, Dec 10, 2015 at 12:11 AM, Andy Shevchenko
> <andy.shevchenko@...il.com> wrote:
> > On Wed, Dec 9, 2015 at 11:59 PM, Joe Perches <joe@...ches.com> wrote:
> > > There are use cases for dumping buffers with specific endian types
> > > for 2, 4, and 8 byte variables in arrays.
> > > 
> > > Add an enum for DUMP_TYPE_(LE|BE|CPU) to enable emitting them as such.
> > > 
> > > Rename groupsize to groupflags in the functions and add documentation
> > > to the kernel-doc to describe the use of the DUMP_TYPE_ enum.
> > 
> > One comment below and my tag
> > Acked-by: Andy Shevchenko <andy.shevchenko@...il.com>
> 
> Couple of additional notes. (Tag still in power)
> 
> 1. There is similar to print_hex_dump() function in seq_file. Separate patch?

Let's see if anyone wants this one first.

> 2. What to do with ASCII part? Shall we print it as byte stream?

It's still emitted as a byte stream.

> And one more style comment below.

That one's a nit I don't care about.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/