linux-kernel - Re: [PATCH V1] input: da9063: report KEY_POWER instead of KEY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 9 Dec 2015 09:17:04 -0800
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	Steve Twiss <stwiss.opensource@...semi.com>
Cc:	LINUX-INPUT <linux-input@...r.kernel.org>,
	LINUXKERNEL <linux-kernel@...r.kernel.org>,
	David Dajun Chen <david.chen@...semi.com>,
	Support Opensource <support.opensource@...semi.com>
Subject: Re: [PATCH V1] input: da9063: report KEY_POWER instead of KEY_SLEEP
 during power key-press

On Tue, Dec 08, 2015 at 05:55:05PM +0000, Steve Twiss wrote:
> From: Steve Twiss <stwiss.opensource@...semi.com>
> 
> Stop reporting KEY_SLEEP for a short key-press and report KEY_POWER instead
> This change applied to both DA9063 and DA9062 ONKEY drivers.

You need to explain why this change is needed.

> 
> Signed-off-by: Steve Twiss <stwiss.opensource@...semi.com>
> 
> ---
> 
> This patch applies against linux-next and v4.4-rc4
> 
> Regards,
> Steve
> 
> 
>  drivers/input/misc/da9063_onkey.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/input/misc/da9063_onkey.c b/drivers/input/misc/da9063_onkey.c
> index 8eb697d..bb863e0 100644
> --- a/drivers/input/misc/da9063_onkey.c
> +++ b/drivers/input/misc/da9063_onkey.c
> @@ -179,13 +179,13 @@ static irqreturn_t da9063_onkey_irq_handler(int irq, void *data)
>  		input_report_key(onkey->input, KEY_POWER, 1);
>  		input_sync(onkey->input);
>  		schedule_delayed_work(&onkey->work, 0);
> -		dev_dbg(onkey->dev, "KEY_POWER pressed.\n");
> +		dev_dbg(onkey->dev, "KEY_POWER long press.\n");
>  	} else {
> -		input_report_key(onkey->input, KEY_SLEEP, 1);
> +		input_report_key(onkey->input, KEY_POWER, 1);
>  		input_sync(onkey->input);
> -		input_report_key(onkey->input, KEY_SLEEP, 0);
> +		input_report_key(onkey->input, KEY_POWER, 0);
>  		input_sync(onkey->input);
> -		dev_dbg(onkey->dev, "KEY_SLEEP pressed.\n");
> +		dev_dbg(onkey->dev, "KEY_POWER short press.\n");
>  	}
>  
>  	return IRQ_HANDLED;
> -- 
> end-of-patch for PATCH V1
> 

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/