linux-kernel - Re: [PATCH 5/9v2] usb: host: ehci.h: remove direct use of __attribute_

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 10 Dec 2015 11:01:51 +0100
From:	Peter Senna Tschudin <peter.senna@...il.com>
To:	"Geyslan G. Bem" <geyslan@...il.com>
Cc:	Alan Stern <stern@...land.harvard.edu>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 5/9v2] usb: host: ehci.h: remove direct use of
 __attribute__ keyword

On Wed, Dec 09, 2015 at 07:32:34PM -0300, Geyslan G. Bem wrote:
> Prefer to use __aligned(size) macro instead of
> __attribute__((aligned(size))).
> 
> Caught by checkpatch: "WARNING"
Not sure about the WARNING here, maybe just remove this line?

> 
> Signed-off-by: Geyslan G. Bem <geyslan@...il.com>
As with previous, missing the changelog, but other than that the patch
looks good to me.

Acked-by: Peter Senna Tschudin <peter.senna@...il.com>
> ---
>  drivers/usb/host/ehci.h | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/usb/host/ehci.h b/drivers/usb/host/ehci.h
> index 945000a..7b2b213 100644
> --- a/drivers/usb/host/ehci.h
> +++ b/drivers/usb/host/ehci.h
> @@ -324,7 +324,7 @@ struct ehci_qtd {
>  	struct list_head	qtd_list;		/* sw qtd list */
>  	struct urb		*urb;			/* qtd's urb */
>  	size_t			length;			/* length of buffer */
> -} __attribute__ ((aligned (32)));
> +} __aligned(32);
>  
>  /* mask NakCnt+T in qh->hw_alt_next */
>  #define QTD_MASK(ehci)	cpu_to_hc32(ehci, ~0x1f)
> @@ -407,7 +407,7 @@ struct ehci_qh_hw {
>  	__hc32			hw_token;
>  	__hc32			hw_buf[5];
>  	__hc32			hw_buf_hi[5];
> -} __attribute__ ((aligned(32)));
> +} __aligned(32);
>  
>  struct ehci_qh {
>  	struct ehci_qh_hw	*hw;		/* Must come first */
> @@ -535,7 +535,7 @@ struct ehci_itd {
>  	unsigned		frame;		/* where scheduled */
>  	unsigned		pg;
>  	unsigned		index[8];	/* in urb->iso_frame_desc */
> -} __attribute__ ((aligned (32)));
> +} __aligned(32);
>  
>  /*-------------------------------------------------------------------------*/
>  
> @@ -578,7 +578,7 @@ struct ehci_sitd {
>  	struct list_head	sitd_list;	/* list of stream's sitds */
>  	unsigned		frame;
>  	unsigned		index;
> -} __attribute__ ((aligned (32)));
> +} __aligned(32);
>  
>  /*-------------------------------------------------------------------------*/
>  
> @@ -598,7 +598,7 @@ struct ehci_fstn {
>  	/* the rest is HCD-private */
>  	dma_addr_t		fstn_dma;
>  	union ehci_shadow	fstn_next;	/* ptr to periodic q entry */
> -} __attribute__ ((aligned (32)));
> +} __aligned(32);
>  
>  /*-------------------------------------------------------------------------*/
>  
> -- 
> 2.6.3
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/