linux-kernel - Re: [PATCH] usb: remove redundant conditions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 10 Dec 2015 09:37:26 -0600
From:	Felipe Balbi <balbi@...com>
To:	"Geyslan G. Bem" <geyslan@...il.com>
CC:	Peter Senna Tschudin <peter.senna@...il.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Johan Hovold <johan@...nel.org>,
	Robert Baldyga <r.baldyga@...sung.com>,
	<linux-usb@...r.kernel.org>, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] usb: remove redundant conditions


Hi,

"Geyslan G. Bem" <geyslan@...il.com> writes:
> 2015-12-10 12:13 GMT-03:00 Felipe Balbi <balbi@...com>:
>> "Geyslan G. Bem" <geyslan@...il.com> writes:
>>
>>> This patch removes redundant conditions.
>>>
>>>  - (!A || (A && B)) is the same as (!A || B).
>>>  - (length && length > 5) can be reduced to a single evaluation.
>>>
>>> Caught by: cppcheck
>>>
>>> Signed-off-by: Geyslan G. Bem <geyslan@...il.com>
>>> ---
>>
>> I guess you didn't get previous comment in time; let's split this per
>> driver so different maintainers can pick their parts.
>
> Okeydokey. :)

thanks :-)

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (819 bytes)