linux-kernel - Re: [PATCH] hisi_sas: use platform_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 10 Dec 2015 14:08:42 -0600
From:	Rob Herring <robh@...nel.org>
To:	John Garry <john.garry@...wei.com>
Cc:	"James E.J. Bottomley" <JBottomley@...n.com>,
	martin.petersen@...cle.com, Arnd Bergmann <arnd@...db.de>,
	Linuxarm <linuxarm@...wei.com>,
	Zhangfei Gao <zhangfei.gao@...aro.org>,
	Wei Xu <xuwei5@...ilicon.com>,
	John Garry <john.garry2@...l.dcu.ie>,
	linux-scsi@...r.kernel.org,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] hisi_sas: use platform_get_irq()

On Thu, Dec 10, 2015 at 9:02 AM, John Garry <john.garry@...wei.com> wrote:
> It is preferred that drivers use platform_get_irq()
> instead of irq_of_parse_and_map(), so replace.

You may be able to stop including of_irq.h with this change. Otherwise,

Acked-by: Rob Herring <robh@...nel.org>

>
> Signed-off-by: John Garry <john.garry@...wei.com>
>
> diff --git a/drivers/scsi/hisi_sas/hisi_sas_v1_hw.c b/drivers/scsi/hisi_sas/hisi_sas_v1_hw.c
> index 89ae31d..e907758 100644
> --- a/drivers/scsi/hisi_sas/hisi_sas_v1_hw.c
> +++ b/drivers/scsi/hisi_sas/hisi_sas_v1_hw.c
> @@ -1673,19 +1673,16 @@ static irq_handler_t fatal_interrupts[HISI_SAS_MAX_QUEUES] = {
>
>  static int interrupt_init_v1_hw(struct hisi_hba *hisi_hba)
>  {
> -       struct device *dev = &hisi_hba->pdev->dev;
> -       struct device_node *np = dev->of_node;
> +       struct platform_device *pdev = hisi_hba->pdev;
> +       struct device *dev = &pdev->dev;
>         int i, j, irq, rc, idx;
>
> -       if (!np)
> -               return -ENOENT;
> -
>         for (i = 0; i < hisi_hba->n_phy; i++) {
>                 struct hisi_sas_phy *phy = &hisi_hba->phy[i];
>
>                 idx = i * HISI_SAS_PHY_INT_NR;
>                 for (j = 0; j < HISI_SAS_PHY_INT_NR; j++, idx++) {
> -                       irq = irq_of_parse_and_map(np, idx);
> +                       irq = platform_get_irq(pdev, idx);
>                         if (!irq) {
>                                 dev_err(dev,
>                                         "irq init: fail map phy interrupt %d\n",
> @@ -1706,7 +1703,7 @@ static int interrupt_init_v1_hw(struct hisi_hba *hisi_hba)
>
>         idx = hisi_hba->n_phy * HISI_SAS_PHY_INT_NR;
>         for (i = 0; i < hisi_hba->queue_count; i++, idx++) {
> -               irq = irq_of_parse_and_map(np, idx);
> +               irq = platform_get_irq(pdev, idx);
>                 if (!irq) {
>                         dev_err(dev, "irq init: could not map cq interrupt %d\n",
>                                 idx);
> @@ -1724,7 +1721,7 @@ static int interrupt_init_v1_hw(struct hisi_hba *hisi_hba)
>
>         idx = (hisi_hba->n_phy * HISI_SAS_PHY_INT_NR) + hisi_hba->queue_count;
>         for (i = 0; i < HISI_SAS_FATAL_INT_NR; i++, idx++) {
> -               irq = irq_of_parse_and_map(np, idx);
> +               irq = platform_get_irq(pdev, idx);
>                 if (!irq) {
>                         dev_err(dev, "irq init: could not map fatal interrupt %d\n",
>                                 idx);
> --
> 1.9.1
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/