linux-kernel - Re: [PATCH 2/2] staging: COMEDI: Added missing spaces at binary operators

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 10 Dec 2015 12:22:41 -0800
From:	Joe Perches <joe@...ches.com>
To:	Moritz König <moritz.koenig@....de>,
	Ian Abbott <abbotti@....co.uk>,
	H Hartley Sweeten <hsweeten@...ionengravers.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Colin Cronin <colinpatrickcronin@...il.com>,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Cc:	Fabian Lang <fabian.lang@....de>, linux-kernel@...cs.fau.de
Subject: Re: [PATCH 2/2] staging: COMEDI: Added missing spaces at binary
 operators

On Thu, 2015-12-10 at 15:57 +0100, Moritz König wrote:
> #define CR_AREF(a)     (((a) >> 24)&0x03)

If you are going to fix these, it'd probably be better
to use spaces around the '&' too

#define CR_AREF(a)     (((a) >> 24) & 0x03)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/