linux-kernel - Re: [PATCH] Staging: speakup: varhandlers: cleanup of function spk_get_punc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 12 Dec 2015 11:40:25 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
Cc:	Saurabh Sengar <saurabh.truth@...il.com>,
	devel@...verdev.osuosl.org, kirk@...sers.ca,
	gregkh@...uxfoundation.org, speakup@...ux-speakup.org,
	linux-kernel@...r.kernel.org, samuel.thibault@...-lyon.org,
	chris@...-brannons.com
Subject: Re: [PATCH] Staging: speakup: varhandlers: cleanup of function
 spk_get_punc_var

On Wed, Dec 09, 2015 at 10:47:18AM +0530, Sudip Mukherjee wrote:
> On Mon, Dec 07, 2015 at 06:35:11PM +0530, Saurabh Sengar wrote:
> > This patch does the following:
> > * changed the complicated if statements to simple case statements
> > * in case of E_DEFAULT, no need to return error as ERESTART,
> > because this is the user asked for. Hence function should return success.
> > * ret variable is 0 always, hence removed it.
> > * removed one ternary operator, as it was always returning the status value only,
> > and hence removed the status variable too
> 
> That becomes 4 different changes. Please break them into separate
> patches.

It's cleaning up one function so you could argue that it's just one
thing.  Sometimes it's actually harder to review when a patch is broken
into ultra tiny junks.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/