[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Fri, 11 Dec 2015 17:10:56 -0800
From: Brian Norris <computersforpeace@...il.com>
To: Arnd Bergmann <arnd@...db.de>
Cc: linux-mtd@...ts.infradead.org,
David Woodhouse <dwmw2@...radead.org>,
Roger Quadros <rogerq@...com>, linux-kernel@...r.kernel.org,
linux-omap@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
Tony Lindgren <tony@...mide.com>
Subject: Re: [PATCH] mtd: omap_elm: print interrupt resource using %pr
Hi Arnd,
On Tue, Dec 08, 2015 at 04:39:45PM +0100, Arnd Bergmann wrote:
> When CONFIG_LPAE is set on ARM, resource_size_t is 64-bit wide
> and we get a warning about an incorrect format string for printing
> the interrupt number in elm_probe:
>
> drivers/mtd/nand/omap_elm.c: In function 'elm_probe':
> drivers/mtd/nand/omap_elm.c:417:23: warning: format '%i' expects argument of type 'int', but argument 3 has type 'resource_size_t {aka long long unsigned int}' [-Wformat=]
>
> This patch avoids the type mismatch by printing the interrupt as
> a resource using the %pr format string.
>
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
> drivers/mtd/nand/omap_elm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/nand/omap_elm.c b/drivers/mtd/nand/omap_elm.c
> index 235ec7992b4c..11f174b07217 100644
> --- a/drivers/mtd/nand/omap_elm.c
> +++ b/drivers/mtd/nand/omap_elm.c
> @@ -414,7 +414,7 @@ static int elm_probe(struct platform_device *pdev)
> ret = devm_request_irq(&pdev->dev, irq->start, elm_isr, 0,
> pdev->name, info);
> if (ret) {
> - dev_err(&pdev->dev, "failure requesting irq %i\n", irq->start);
> + dev_err(&pdev->dev, "failure requesting %pr\n", &irq);
drivers/mtd/nand/omap_elm.c:417 elm_probe() error: '%pr' expects argument of type struct resource *, but argument 3 has type 'struct resource**' [smatch]
> return ret;
> }
>
Brian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists