lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 13 Dec 2015 03:13:46 +0200 From: Andy Shevchenko <andy.shevchenko@...il.com> To: Dmitry Krivenok <krivenok.dmitry@...il.com>, Rasmus Villemoes <linux@...musvillemoes.dk> Cc: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: Re: [PATCH 1/1] Remove unneeded "0x" when %pa formatting is used. On Mon, Nov 30, 2015 at 10:33 PM, Dmitry Krivenok <krivenok.dmitry@...il.com> wrote: >>> if (size > max_size) { >>> dev_err(pcie->dev, >>> - "res size 0x%pap exceeds max supported size 0x%llx\n", >>> + "res size %pap exceeds max supported size 0x%llx\n", >> >> %pa also works. >> > > Yes, but AFAIK %pap and %pa are identical (see address_val() in lib/vsprintf.c), > so I'm not sure I understand your comment. > > Did you mean that %pa should be used instead of %pap? > I see that %pa is used much more often than %pap, but I didn't find any > evidence that %pap is deprecated. +Rasmus. No, it's not, but it explicitly for phys_addr_t (it might be nice to to have %par, for example for explicitly shown that is for resource_size_t, Rasmus?). For my opinion for resources better to use %pa for now, though %pap will work as well. -- With Best Regards, Andy Shevchenko -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists