linux-kernel - Re: [PATCH v2] Input: xpad - remove spurious events of wireless xpad 360 controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 12 Dec 2015 21:21:16 -0800
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	clement.calmels@...e.fr
Cc:	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] Input: xpad - remove spurious events of wireless xpad
 360 controller

On Sun, Nov 22, 2015 at 05:35:39PM +0100, clement.calmels@...e.fr wrote:
> From: Clement Calmels <clement.calmels@...e.fr>
> 
> When powering up a wireless xbox 360 controller, some wrong joystick
> events are generated. It is annoying because, for example, it makes
> unwanted moves in Steam big picture mode's menu.
> 
> When my controller is powering up, this packet is received by the
> driver:
> 00000000: 00 0f 00 f0 00 cc ff cf 8b e0 86 6a 68 f0 00 20  ...........jh..
> 00000010: 13 e3 20 1d 30 03 40 01 50 01 ff ff              .. .0.@.....
> 
> According to xboxdrv userspace driver source code, this packet is only
> dumping a serial id and should not be interpreted as joystick events.
> This issue can be easily seen with jstest:
> $ jstest --event /dev/input/js0
> 
> This patch only adds a way to filter out this "serial" packet and as a
> result it removes the spurous events.
> 
> Signed-off-by: Clement Calmels <clement.calmels@...e.fr>

Applied, thank you.

> ---
>  drivers/input/joystick/xpad.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/input/joystick/xpad.c b/drivers/input/joystick/xpad.c
> index fd4100d..c44cbd4 100644
> --- a/drivers/input/joystick/xpad.c
> +++ b/drivers/input/joystick/xpad.c
> @@ -527,7 +527,7 @@ static void xpad360w_process_packet(struct usb_xpad *xpad, u16 cmd, unsigned cha
>  	}
>  
>  	/* Valid pad data */
> -	if (!(data[1] & 0x1))
> +	if (data[1] != 0x1)
>  		return;
>  
>  	xpad360_process_packet(xpad, cmd, &data[4]);
> -- 
> 2.6.2
> 

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/