linux-kernel - RE: [char-misc for v4.4] mei: fix fasync return value on error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 14 Dec 2015 09:18:13 +0000
From:	"Winkler, Tomas" <tomas.winkler@...el.com>
To:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Al Viro <viro@...IV.linux.org.uk>
CC:	"Usyskin, Alexander" <alexander.usyskin@...el.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"stable@...r.kernel.org" <stable@...r.kernel.org>
Subject: RE: [char-misc for v4.4] mei: fix fasync return value on error

> fasync should return a negative value on error
> and not poll mask POLLERR.
> 
> Cc: <stable@...r.kernel.org> # 4.3+
> Reported-by: Al Viro <viro@...IV.linux.org.uk>
> Signed-off-by: Tomas Winkler <tomas.winkler@...el.com>
> ---
>  drivers/misc/mei/main.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/misc/mei/main.c b/drivers/misc/mei/main.c
> index b2f2486b3d75..677d0362f334 100644
> --- a/drivers/misc/mei/main.c
> +++ b/drivers/misc/mei/main.c
> @@ -657,7 +657,9 @@ out:
>   * @file: pointer to file structure
>   * @band: band bitmap
>   *
> - * Return: poll mask
> + * Return: negative on error,
> + *         0 if it did no changes,
> + *         and positive a process was added or deleted
>   */
>  static int mei_fasync(int fd, struct file *file, int band)
>  {
> @@ -665,7 +667,7 @@ static int mei_fasync(int fd, struct file *file, int band)
>  	struct mei_cl *cl = file->private_data;
> 
>  	if (!mei_cl_is_connected(cl))
> -		return POLLERR;
> +		return -ENODEV;
> 
>  	return fasync_helper(fd, file, band, &cl->ev_async);
>  }

Greg, I saw this patch wasn't applied in rc5, any comments on the patch?
Thanks
Tomas

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/