linux-kernel - Re: [PATCH RESEND 22/27] tools/hv: Use include/uapi with __EXPORTED_HEADERS_

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 14 Dec 2015 19:11:09 -0800
From:	Greg KH <gregkh@...uxfoundation.org>
To:	"K. Y. Srinivasan" <kys@...rosoft.com>
Cc:	linux-kernel@...r.kernel.org, devel@...uxdriverproject.org,
	olaf@...fle.de, apw@...onical.com, vkuznets@...hat.com,
	jasowang@...hat.com, Kamal Mostafa <kamal@...onical.com>
Subject: Re: [PATCH RESEND 22/27] tools/hv: Use include/uapi with
 __EXPORTED_HEADERS__

On Mon, Dec 14, 2015 at 04:01:53PM -0800, K. Y. Srinivasan wrote:
> From: Kamal Mostafa <kamal@...onical.com>
> 
> Use the local uapi headers to keep in sync with "recently" added #define's
> (e.g. VSS_OP_REGISTER1).
> 
> Fixes: 3eb2094c59e89db2bedd401e23c7a870081c9edb

Please use the "correct" way of listing this:
	3eb2094c59e8 ("Adding makefile for tools/hv")

And as this is an old kernel, shouldn't it go into stable releases?  Or
does that mean that no one really ever runs into this issue?

> Signed-off-by: Kamal Mostafa <kamal@...onical.com>
> Signed-off-by: K. Y. Srinivasan <kys@...rosoft.com>
> ---
>  tools/hv/Makefile |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/tools/hv/Makefile b/tools/hv/Makefile
> index a8ab795..a8c4644 100644
> --- a/tools/hv/Makefile
> +++ b/tools/hv/Makefile
> @@ -5,6 +5,8 @@ PTHREAD_LIBS = -lpthread
>  WARNINGS = -Wall -Wextra
>  CFLAGS = $(WARNINGS) -g $(PTHREAD_LIBS) $(shell getconf LFS_CFLAGS)
>  
> +CFLAGS += -D__EXPORTED_HEADERS__ -I../../include/uapi -I../../include

Why do you need ../../include also?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/