linux-kernel - Re: [PATCH 08/11] tty: serial: 8250: Add parentheses to macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 18 Dec 2015 14:35:15 +0200
From:	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:	anton.wuerfel@....de
Cc:	linux-kernel@...r.kernel.org, linux-parisc@...r.kernel.org,
	linux-kernel@...cs.fau.de, phillip.raffeck@....de
Subject: Re: [PATCH 08/11] tty: serial: 8250: Add parentheses to macro

On Fri, 2015-12-18 at 12:36 +0100, anton.wuerfel@....de wrote:
> Hello Andy,
> 
> > What about the rest of the drivers under drivers/tty/serial?
> > 
> > What do you propose to do with, for example, the following
> > 
> > drivers/tty/serial/cpm_uart/cpm_uart_core.c:1392:#define
> > CPM_UART_CONSOLE       &cpm_scc_uart_console
> > drivers/tty/serial/cpm_uart/cpm_uart_core.c:1394:#define
> > CPM_UART_CONSOLE       NULL
> > 
> > >  #else
> > >  #define SERIAL8250_CONSOLE	NULL
> > >  #endif
> > 
> 
> thanks for your reply. Phillip and me are newcomers to kernel
> development,

Welcome!

> so we tried to touch as few files as possible and gain some
> experience in
> creating patches and communication on LKML. We will consider sending
> further patches in the future.

I see.

I don't know which way is preferable for such patches, I think Greg
usually likes when one patch touches one driver. So, this one is okay,
and other drivers can be fixed later.



> Regards,
> Phillip Raffeck
> Anton Wuerfel
> 
> > --
> > Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> > Intel Finland Oy
> > 
> > 
> 
> 

-- 
Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Intel Finland Oy

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/