linux-kernel - Re: [PATCH] serial: 8250: of: Fix the driver and actually compile the 8250

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 18 Dec 2015 13:52:33 +0100
From:	Arnd Bergmann <arnd@...db.de>
To:	Peter Ujfalusi <peter.ujfalusi@...com>
Cc:	gregkh@...uxfoundation.org, linux-arm-kernel@...ts.infradead.org,
	linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] serial: 8250: of: Fix the driver and actually compile the 8250_of

On Friday 18 December 2015 14:43:32 Peter Ujfalusi wrote:
> The 8250_of never compiled since in the Kconfig we have SERIAL_OF_PLATFORM
> but in the makefile we expect to have SERIAL_8250_OF...
> 
> In the Kconfig keep the SERIAL_OF_PLATFORM for compatibility reasons and
> let it select the SERIAL_8250_OF. Later we can replace the
> SERIAL_OF_PLATFORM use in defconfigs to SERIAL_8250_OF.
> 
> When the 8250_of.c is actually compiled we will have two errors:
> missing linux/nwpserial.h and 8250/8250.h.
> Fix those as well at the same time when enable the compilation of the
> driver.
> 
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@...com>
> Fixes: afd7f88f1577 ("serial: 8250: move of_serial code to 8250 directory")
> CC: Arnd Bergmann <arnd@...db.de>
> ---

Thanks for the report. Indeed this could not have worked.

> diff --git a/drivers/tty/serial/8250/Kconfig b/drivers/tty/serial/8250/Kconfig
> index b03cb5175113..01f24613b0e6 100644
> --- a/drivers/tty/serial/8250/Kconfig
> +++ b/drivers/tty/serial/8250/Kconfig
> @@ -379,6 +379,11 @@ config SERIAL_8250_MID
>           Intel platforms.
>  
>  config SERIAL_OF_PLATFORM
> +       tristate
> +       depends on SERIAL_8250 && OF
> +       select SERIAL_8250_OF
> +
> +config SERIAL_8250_OF
>         tristate "Devicetree based probing for 8250 ports"
>         depends on SERIAL_8250 && OF
>         help

This will still require changing all the defconfigs, as SERIAL_OF_PLATFORM
is a silent option now. I think it's better to change the Makefile and
leave the slightly odd Kconfig symbol name.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/