linux-kernel - Re: [PATCH v2] mtd: spi-nor: fsl-quadspi: add big-endian support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 18 Dec 2015 14:55:08 -0800
From:	Brian Norris <computersforpeace@...il.com>
To:	Yao Yuan <yao.yuan@...escale.com>
Cc:	"dwmw2@...radead.org" <dwmw2@...radead.org>,
	Xu Han <han.xu@...escale.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-mtd@...ts.infradead.org" <linux-mtd@...ts.infradead.org>
Subject: Re: [PATCH v2] mtd: spi-nor: fsl-quadspi: add big-endian support

On Fri, Dec 18, 2015 at 09:12:13AM +0000, Yao Yuan wrote:
> Hi Woodhouse, Norris,
> 
> Do you have any comments for this patch?

No, it looks fine. But the driver maintainer (Han) already asked you for
DT binding documentation already. This is a requirement before I can
merge your patch. See
Documentation/devicetree/bindings/submitting-patches.txt.

> Thanks for your review.
> 
> Best Regards,
> Yuan Yao
> 
> > -----Original Message-----
> > From: Han Xu [mailto:han.xu@...escale.com]

> > > +	q->big_endian = of_property_read_bool(np, "big-endian");
> > 
> > I am fine with this patch, but need document the new property with another
> > patch

^^^ See here

Brian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/