lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 20 Dec 2015 08:18:01 +0100 From: Marcel Holtmann <marcel@...tmann.org> To: Nicholas Krause <xerofoify@...il.com> Cc: "Gustavo F. Padovan" <gustavo@...ovan.org>, Johan Hedberg <johan.hedberg@...il.com>, "David S. Miller" <davem@...emloft.net>, linux-bluetooth@...r.kernel.org, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] bluetooth:Fix variable assignment for internal function returns in the function l2cap_bredr_sig_cmd Hi Nick, > This makes all internal functions that can return a error code to > properly signal this to the caller of the function l2cap_bredr_sig_cmd > by making their return value equal to the variable err before returning > to the caller of the function l2cap_bredr_sig_cmd with this value > as to allow us to correctly signal when a failure has occurred when > this particular function is called. > > Signed-off-by: Nicholas Krause <xerofoify@...il.com> > --- > net/bluetooth/l2cap_core.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/net/bluetooth/l2cap_core.c b/net/bluetooth/l2cap_core.c > index 7c65ee2..488eebe 100644 > --- a/net/bluetooth/l2cap_core.c > +++ b/net/bluetooth/l2cap_core.c > @@ -5319,7 +5319,7 @@ static inline int l2cap_bredr_sig_cmd(struct l2cap_conn *conn, > > switch (cmd->code) { > case L2CAP_COMMAND_REJ: > - l2cap_command_rej(conn, cmd, cmd_len, data); > + err = l2cap_command_rej(conn, cmd, cmd_len, data); > break; this patch is wrong. Please try to understand on how L2CAP works and look up what the caller of l2cap_bredr_sig_cmd does with the return code. Responses can not cause another command reject. Regards Marcel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists