linux-kernel - Re: [PATCH] sc16is7xx: fix incorrect register bits macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 19 Dec 2015 16:43:03 -0800
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Wills Wang <wills.wang@...e.com>
Cc:	jringle@...dpoint.com, linux-kernel@...r.kernel.org,
	linux-serial@...r.kernel.org
Subject: Re: [PATCH] sc16is7xx: fix incorrect register bits macro

On Sat, Dec 19, 2015 at 07:20:06PM +0800, Wills Wang wrote:
> In datasheet, Modem Status Register MSR[4-5] reflect the modem pins
> CTS/DSR/RI/CD signal state.
> 
> Signed-off-by: Wills Wang <wills.wang@...e.com>
> ---
>  drivers/tty/serial/sc16is7xx.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/tty/serial/sc16is7xx.c b/drivers/tty/serial/sc16is7xx.c
> index edb5305..9d18c24 100644
> --- a/drivers/tty/serial/sc16is7xx.c
> +++ b/drivers/tty/serial/sc16is7xx.c
> @@ -196,14 +196,14 @@
>  						  * or (IO6)
>  						  * - only on 75x/76x
>  						  */
> -#define SC16IS7XX_MSR_CTS_BIT		(1 << 0) /* CTS */
> -#define SC16IS7XX_MSR_DSR_BIT		(1 << 1) /* DSR (IO4)
> +#define SC16IS7XX_MSR_CTS_BIT		(1 << 4) /* CTS */
> +#define SC16IS7XX_MSR_DSR_BIT		(1 << 5) /* DSR (IO4)

BIT(4)  BIT(5)?

Please do that at the same time...

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/