linux-kernel - Re: [PATCH V2 06/23] XEN / PCI: Remove the dependence on arch x86 when PCI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 21 Dec 2015 18:12:14 +0000
From:	Stefano Stabellini <stefano.stabellini@...citrix.com>
To:	Tomasz Nowicki <tn@...ihalf.com>
CC:	<bhelgaas@...gle.com>, <arnd@...db.de>, <will.deacon@....com>,
	<catalin.marinas@....com>, <rjw@...ysocki.net>,
	<hanjun.guo@...aro.org>, <Lorenzo.Pieralisi@....com>,
	<okaya@...eaurora.org>, <jiang.liu@...ux.intel.com>,
	<Stefano.Stabellini@...citrix.com>,
	<robert.richter@...iumnetworks.com>, <mw@...ihalf.com>,
	<Liviu.Dudau@....com>, <ddaney@...iumnetworks.com>,
	<tglx@...utronix.de>, <wangyijing@...wei.com>,
	<Suravee.Suthikulpanit@....com>, <msalter@...hat.com>,
	<linux-pci@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>,
	<linux-acpi@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<linaro-acpi@...ts.linaro.org>, <jchandra@...adcom.com>,
	<jcm@...hat.com>, Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>,
	Boris Ostrovsky <boris.ostrovsky@...cle.com>
Subject: Re: [PATCH V2 06/23] XEN / PCI: Remove the dependence on arch x86
 when PCI_MMCONFIG=y

On Wed, 16 Dec 2015, Tomasz Nowicki wrote:
> In drivers/xen/pci.c, there are arch x86 dependent codes when
> CONFIG_PCI_MMCONFIG is enabled, since CONFIG_PCI_MMCONFIG
> depends on ACPI, so this will prevent XEN PCI running on other
> architectures using ACPI with PCI_MMCONFIG enabled (such as ARM64).
> 
> Fortunatly, it can be sloved in a simple way. In drivers/xen/pci.c,
> the only x86 dependent code is if ((pci_probe & PCI_PROBE_MMCONF) == 0),
> and it's defined in asm/pci_x86.h, the code means that
> if the PCI resource is not probed in PCI_PROBE_MMCONF way, just
> ingnore the xen mcfg init. Actually this is duplicate, because
> if PCI resource is not probed in PCI_PROBE_MMCONF way, the
> pci_mmconfig_list will be empty, and the if (list_empty())
> after it will do the same job.
> 
> So just remove the arch related code and the head file, this
> will be no functional change for x86, and also makes xen/pci.c
> usable for other architectures.
> 
> Signed-off-by: Hanjun Guo <hanjun.guo@...aro.org>
> CC: Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
> CC: Boris Ostrovsky <boris.ostrovsky@...cle.com>
> Cc: Stefano Stabellini <Stefano.Stabellini@...citrix.com>
> Tested-by: Suravee Suthikulpanit <Suravee.Suthikulpanit@....com>

Acked-by: Stefano Stabellini <stefano.stabellini@...citrix.com>


>  drivers/xen/pci.c | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/drivers/xen/pci.c b/drivers/xen/pci.c
> index 6785ebb..9a8dbe3 100644
> --- a/drivers/xen/pci.c
> +++ b/drivers/xen/pci.c
> @@ -28,9 +28,6 @@
>  #include <asm/xen/hypervisor.h>
>  #include <asm/xen/hypercall.h>
>  #include "../pci/pci.h"
> -#ifdef CONFIG_PCI_MMCONFIG
> -#include <asm/pci_x86.h>
> -#endif
>  
>  static bool __read_mostly pci_seg_supported = true;
>  
> @@ -222,9 +219,6 @@ static int __init xen_mcfg_late(void)
>  	if (!xen_initial_domain())
>  		return 0;
>  
> -	if ((pci_probe & PCI_PROBE_MMCONF) == 0)
> -		return 0;
> -
>  	if (list_empty(&pci_mmcfg_list))
>  		return 0;
>  
> -- 
> 1.9.1
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/