lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Tue, 22 Dec 2015 08:33:16 +0100
From:	Hannes Reinecke <hare@...e.de>
To:	Finn Thain <fthain@...egraphics.com.au>,
	"James E.J. Bottomley" <JBottomley@...n.com>,
	Michael Schmitz <schmitzmic@...il.com>,
	linux-m68k@...r.kernel.org, linux-scsi@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	"Martin K. Petersen" <martin.petersen@...cle.com>
Subject: Re: [PATCH v3 37/77] ncr5380: Standardize work queueing algorithm

On 12/22/2015 02:18 AM, Finn Thain wrote:
> The complex main_running/queue_main mechanism is peculiar to
> atari_NCR5380.c. It isn't SMP safe and offers little value given that
> the work queue already offers concurrency management. Remove this
> complexity to bring atari_NCR5380.c closer to NCR5380.c.
>
> It is not a good idea to call the information transfer state machine from
> queuecommand because, according to Documentation/scsi/scsi_mid_low_api.txt
> that could happen in soft irq context. Fix this.
>
> Signed-off-by: Finn Thain <fthain@...egraphics.com.au>
>
> ---
>   drivers/scsi/NCR5380.h       |    1
>   drivers/scsi/atari_NCR5380.c |   80 +++----------------------------------------
>   2 files changed, 6 insertions(+), 75 deletions(-)
>
Reviewed-by: Hannes Reinecke <hare@...e.com>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		      zSeries & Storage
hare@...e.de			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ