linux-kernel - Re: [PATCH 2/2] irqchip/gic: Only populate set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 22 Dec 2015 09:21:59 +0000
From:	Jon Hunter <jonathanh@...dia.com>
To:	kbuild test robot <lkp@...el.com>
CC:	<kbuild-all@...org>, Thomas Gleixner <tglx@...utronix.de>,
	Jason Cooper <jason@...edaemon.net>,
	Marc Zyngier <marc.zyngier@....com>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] irqchip/gic: Only populate set_affinity for the root
 controller


On 22/12/15 01:00, kbuild test robot wrote:
> Hi Jon,
> 
> [auto build test ERROR on tip/irq/core]
> [also build test ERROR on next-20151221]
> [cannot apply to v4.4-rc6]
> 
> url:    https://github.com/0day-ci/linux/commits/Jon-Hunter/irqchip-gic-Remove-static-irq_chip-definition-for-eoimode1/20151221-221639
> config: arm-realview_defconfig (attached as .config)
> reproduce:
>         wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # save the attached .config to linux build tree
>         make.cross ARCH=arm 
> 
> All errors (new ones prefixed by >>):
> 
>    drivers/irqchip/irq-gic.c: In function '__gic_init_bases':
>>> drivers/irqchip/irq-gic.c:1019:33: error: 'gic_set_affinity' undeclared (first use in this function)
>        gic->chip.irq_set_affinity = gic_set_affinity;
>                                     ^
>    drivers/irqchip/irq-gic.c:1019:33: note: each undeclared identifier is reported only once for each function it appears in
> 
> vim +/gic_set_affinity +1019 drivers/irqchip/irq-gic.c
> 
>   1013		gic->chip = gic_chip;
>   1014		gic->chip.name = kasprintf(GFP_KERNEL, "GIC-%d", gic_nr);
>   1015	
>   1016		/* Initialize irq_chip */
>   1017		if (gic_nr == 0) {
>   1018			if (IS_ENABLED(CONFIG_SMP))
>> 1019				gic->chip.irq_set_affinity = gic_set_affinity;
>   1020	
>   1021			if (static_key_true(&supports_deactivate)) {
>   1022				gic->chip.irq_mask = gic_eoimode1_mask_irq;
> 

Thanks. Yes if CONFIG_SMP is not defined then I see this error. I had
naively assumed that IS_ENABLED() would handle this for me. I will fix this.

Cheers
Jon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/