linux-kernel - Re: [PATCH 2/3] mmc: sdhci-pci: Add platform tuning callback for amd hs200 mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 23 Dec 2015 08:18:18 +0800
From:	Wan ZongShun <mcuos.com@...il.com>
To:	Andy Shevchenko <andy.shevchenko@...il.com>
Cc:	Wan Zongshun <vincent.wan@....com>,
	Ulf Hansson <ulf.hansson@...aro.org>,
	"linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>,
	Borislav Petkov <bp@...e.de>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Huang Rui <ray.huang@....com>
Subject: Re: [PATCH 2/3] mmc: sdhci-pci: Add platform tuning callback for amd
 hs200 mode

>> +
>>  static const struct sdhci_pci_fixes sdhci_amd = {
>>         .probe          = amd_probe,
>> +       .probe_slot     = amd_probe_slot,
>>  };
>>
>>  static const struct pci_device_id pci_ids[] = {
>> @@ -1508,6 +1519,17 @@ static int sdhci_pci_select_drive_strength(struct sdhci_host *host,
>>                                            card_drv, drv_type);
>>  }
>>
>> +static int sdhci_pci_platform_execute_tuning(struct sdhci_host *host,
>> +                                            u32 opcode)
>> +{
>> +       struct sdhci_pci_slot *slot = sdhci_priv(host);
>> +
>> +       if (!slot->platform_execute_tuning)
>> +               return -EPERM;
>
> Here you return an error code.
>
>> +
>> +       return slot->platform_execute_tuning(host, opcode);
>> +}
>> +
>>  static const struct sdhci_ops sdhci_pci_ops = {
>>         .set_clock      = sdhci_set_clock,
>>         .enable_dma     = sdhci_pci_enable_dma,
>> @@ -1516,6 +1538,7 @@ static const struct sdhci_ops sdhci_pci_ops = {
>>         .set_uhs_signaling = sdhci_set_uhs_signaling,
>>         .hw_reset               = sdhci_pci_hw_reset,
>>         .select_drive_strength  = sdhci_pci_select_drive_strength,
>> +       .platform_execute_tuning = sdhci_pci_platform_execute_tuning,
>>  };
>>
>>  /*****************************************************************************\
>> diff --git a/drivers/mmc/host/sdhci-pci.h b/drivers/mmc/host/sdhci-pci.h
>> index d1a0b4d..48d98f1 100644
>> --- a/drivers/mmc/host/sdhci-pci.h
>> +++ b/drivers/mmc/host/sdhci-pci.h
>> @@ -83,6 +83,7 @@ struct sdhci_pci_slot {
>>                                      struct mmc_card *card,
>>                                      unsigned int max_dtr, int host_drv,
>>                                      int card_drv, int *drv_type);
>> +       int (*platform_execute_tuning)(struct sdhci_host *host, u32 opcode);
>>  };
>>
>>  struct sdhci_pci_chip {
>> diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
>> index 2753b722d..2a5a6ce 100644
>> --- a/drivers/mmc/host/sdhci.c
>> +++ b/drivers/mmc/host/sdhci.c
>> @@ -1937,7 +1937,8 @@ static int sdhci_execute_tuning(struct mmc_host *mmc, u32 opcode)
>>                 spin_unlock_irqrestore(&host->lock, flags);
>>                 err = host->ops->platform_execute_tuning(host, opcode);
>>                 sdhci_runtime_pm_put(host);
>> -               return err;
>> +               if (err != EPERM)
>
> …and here you ignore it. Perhaps better to introduce various positive codes
>
> #define AMD_TUNNING_DONE 0
> #define AMD_TUNNING_NA 1

Andy, It looks a good idea, thanks.


>
>
>> +                       return err;
>>         }
>>
>>         ctrl = sdhci_readw(host, SDHCI_HOST_CONTROL2);
>> --
>> 1.9.1
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>> the body of a message to majordomo@...r.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>> Please read the FAQ at  http://www.tux.org/lkml/
>
>
>
> --
> With Best Regards,
> Andy Shevchenko



-- 
---
Vincent Wan(Zongshun)
www.mcuos.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/