lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 23 Dec 2015 00:07:41 +0000 From: André Przywara <andre.przywara@....com> To: Arnd Bergmann <arnd@...db.de>, linux-arm-kernel@...ts.infradead.org Cc: Maxime Ripard <maxime.ripard@...e-electrons.com>, Chen-Yu Tsai <wens@...e.org>, Herbert Xu <herbert@...dor.apana.org.au>, marc.zyngier@....com, catalin.marinas@....com, will.deacon@....com, linux-kernel@...r.kernel.org, linux-sunxi@...glegroups.com, Corentin Labbe <clabbe.montjoie@...il.com>, linux-crypto@...r.kernel.org, "David S. Miller" <davem@...emloft.net> Subject: Re: [RFC PATCH 2/5] crypto: sunxi-ss: fix min3() call to match types Hi Arnd, On 12/22/15 22:06, Arnd Bergmann wrote: > On Tuesday 22 December 2015, Andre Przywara wrote: >> The min3() macro expects all arguments to be of the same type (or >> size at least). While two arguments are ints or u32s, one is size_t, >> which does not match on 64-bit architectures. >> Cast the size_t to u32 to make min3() happy. In this context here the >> length should never exceed 32 bits anyway. >> >> Signed-off-by: Andre Przywara <andre.przywara@....com> > > Looks correct, but a bit ugly. Could we avoid the casts by using > temporary variables to keep the size_t based data? I guess this gets even uglier, but I found a better solution by promoting the other involved variables to size_t in this function. This works nicely for most of the cases, I just need two size_t casts now. Will send an updated version soon. Cheers, Andre. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists