linux-kernel - Re: [PATCH v2] um: Fix build error and kconfig for i386

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 24 Dec 2015 13:09:45 +0100
From:	Mickaël Salaün <mic@...ikod.net>
To:	Josh Triplett <josh@...htriplett.org>
Cc:	linux-kernel@...r.kernel.org, Jeff Dike <jdike@...toit.com>,
	Richard Weinberger <richard@....at>,
	user-mode-linux-devel@...ts.sourceforge.net,
	"Paul E . McKenney" <paulmck@...ux.vnet.ibm.com>,
	Michal Marek <mmarek@...e.cz>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	stable@...r.kernel.org
Subject: Re: [PATCH v2] um: Fix build error and kconfig for i386


On 23/12/2015 22:42, Josh Triplett wrote:
> On Wed, Dec 23, 2015 at 01:59:13PM +0100, Mickaël Salaün wrote:
>> Fix build error by selecting COREDUMP when X86_32 is selected:
>>
>> arch/x86/um/built-in.o: In function `elf_core_write_extra_phdrs':
>> (.text+0x3e62): undefined reference to `dump_emit'
>> arch/x86/um/built-in.o: In function `elf_core_write_extra_data':
>> (.text+0x3eef): undefined reference to `dump_emit'
>>
>> Fixes: 5d2acfc7b974 ("kconfig: make allnoconfig disable options behind EMBEDDED and EXPERT")
>> Signed-off-by: Mickaël Salaün <mic@...ikod.net>
>> Cc: Jeff Dike <jdike@...toit.com>
>> Cc: Richard Weinberger <richard@....at>
>> Cc: Josh Triplett <josh@...htriplett.org>
>> Cc: Paul E. McKenney <paulmck@...ux.vnet.ibm.com>
>> Cc: Michal Marek <mmarek@...e.cz>
>> Cc: Andrew Morton <akpm@...ux-foundation.org>
>> Cc: Linus Torvalds <torvalds@...ux-foundation.org>
> 
> I suppose um doesn't care deeply about binary size, but ideally I would
> suggest changing arch/x86/um/Makefile to make elfcore.c compiled in when
> CONFIG_ELF_CORE rather than CONFIG_BINFMT_ELF.

That looks better! Since the first patch has been added to the mmots tree (but not yet in mmotm) I'll send a patch update instead of a new one reverting the first. I hope this is OK.

Regards,
 Mickaël


Download attachment "signature.asc" of type "application/pgp-signature" (456 bytes)