linux-kernel - Re: [PATCH] gpiolib: Fix uninitialized variable warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 24 Dec 2015 00:16:42 -0800
From:	Bjorn Andersson <bjorn@...o.se>
To:	Ross Zwisler <ross.zwisler@...ux.intel.com>
Cc:	linux-kernel@...r.kernel.org,
	Bamvor Jian Zhang <bamvor.zhangjian@...aro.org>,
	Alexandre Courbot <gnurou@...il.com>,
	Linus Walleij <linus.walleij@...aro.org>,
	linux-gpio@...r.kernel.org
Subject: Re: [PATCH] gpiolib: Fix uninitialized variable warning

On Wed 23 Dec 13:46 PST 2015, Ross Zwisler wrote:

> Commit ef7c7553039b ("gpiolib: improve overlap check of range of gpio")
> introduced the following compiler warning:
> 
> drivers/gpio/gpiolib.c: In function ‘gpiochip_add’:
> drivers/gpio/gpiolib.c:193:20: warning: ‘iterator’ may be used uninitialized in this function [-Wmaybe-uninitialized]
>   struct gpio_chip *iterator;
>                     ^
> 
> Fix this by initializing 'iterator' to NULL.
> 
> Signed-off-by: Ross Zwisler <ross.zwisler@...ux.intel.com>

Reviewed-by: Bjorn Andersson <bjorn.andersson@...ymobile.com>

Regards,
Bjorn

> ---
> 
> This was found in next-20151223.
> 
> ---
>  drivers/gpio/gpiolib.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
> index d72ac1f..abdcd6c 100644
> --- a/drivers/gpio/gpiolib.c
> +++ b/drivers/gpio/gpiolib.c
> @@ -190,7 +190,7 @@ EXPORT_SYMBOL_GPL(gpiod_get_direction);
>  static int gpiochip_add_to_list(struct gpio_chip *chip)
>  {
>  	struct list_head *pos;
> -	struct gpio_chip *iterator;
> +	struct gpio_chip *iterator = NULL;
>  	struct gpio_chip *previous = NULL;
>  
>  	if (list_empty(&gpio_chips)) {
> -- 
> 2.6.3
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/