linux-kernel - [PATCH] surface pro 4: fix compare_const

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 27 Dec 2015 22:10:58 +0100 (CET)
From:	Julia Lawall <julia.lawall@...6.fr>
To:	Weng Xuetian <wengxt@...il.com>
cc:	Chen Yu <yu.c.chen@...el.com>, Darren Hart <dvhart@...radead.org>,
	linux-kernel@...r.kernel.org, platform-driver-x86@...r.kernel.org,
	Weng Xuetian <wengxt@...il.com>, kbuild-all@...org
Subject: [PATCH] surface pro 4: fix compare_const_fl.cocci warnings

Move constants to the right of binary operators.

Generated by: scripts/coccinelle/misc/compare_const_fl.cocci

CC: Weng Xuetian <wengxt@...il.com>
Signed-off-by: Fengguang Wu <fengguang.wu@...el.com>
Signed-off-by: Julia Lawall <julia.lawall@...6.fr>
---

It's not a big deal, but the constant on the right looks nicer to me.  
key_code seems like the more important information, so it is nice to see 
it first.

 surfacepro_button.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/platform/x86/surfacepro_button.c
+++ b/drivers/platform/x86/surfacepro_button.c
@@ -111,7 +111,7 @@ static void surface_button_notify(struct
 		break;
 	}
 	input = button->input;
-	if (KEY_RESERVED == key_code)
+	if (key_code == KEY_RESERVED)
 		return;
 	if (pressed)
 		pm_wakeup_event(&device->dev, 0);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/