lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 27 Dec 2015 13:40:13 +0100 From: SF Markus Elfring <elfring@...rs.sourceforge.net> To: linux-rdma@...r.kernel.org, target-devel@...r.kernel.org, Doug Ledford <dledford@...hat.com>, Hal Rosenstock <hal.rosenstock@...il.com>, Or Gerlitz <ogerlitz@...lanox.com>, Roi Dayan <roid@...lanox.com>, Sagi Grimberg <sagig@...lanox.com>, Sean Hefty <sean.hefty@...el.com> Cc: LKML <linux-kernel@...r.kernel.org>, kernel-janitors@...r.kernel.org, Julia Lawall <julia.lawall@...6.fr> Subject: [PATCH 1/2] InfiniBand-iSER: One jump label less in iser_reg_sig_mr() From: Markus Elfring <elfring@...rs.sourceforge.net> Date: Sun, 27 Dec 2015 11:41:42 +0100 This issue was detected by using the Coccinelle software. 1. Let us return directly if a call of the iser_set_sig_attrs() function failed. 2. Delete the jump label "err" then. 3. Return zero as a constant at the end. Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net> --- drivers/infiniband/ulp/iser/iser_memory.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/infiniband/ulp/iser/iser_memory.c b/drivers/infiniband/ulp/iser/iser_memory.c index ea765fb..14e08b3 100644 --- a/drivers/infiniband/ulp/iser/iser_memory.c +++ b/drivers/infiniband/ulp/iser/iser_memory.c @@ -443,7 +443,7 @@ iser_reg_sig_mr(struct iscsi_iser_task *iser_task, memset(sig_attrs, 0, sizeof(*sig_attrs)); ret = iser_set_sig_attrs(iser_task->sc, sig_attrs); if (ret) - goto err; + return ret; iser_set_prot_checks(iser_task->sc, &sig_attrs->check_mask); @@ -475,8 +475,7 @@ iser_reg_sig_mr(struct iscsi_iser_task *iser_task, iser_dbg("lkey=0x%x rkey=0x%x addr=0x%llx length=%u\n", sig_reg->sge.lkey, sig_reg->rkey, sig_reg->sge.addr, sig_reg->sge.length); -err: - return ret; + return 0; } static int iser_fast_reg_mr(struct iscsi_iser_task *iser_task, -- 2.6.3 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists