linux-kernel - Re: [PATCH] extcon: arizona: Use DAPM mutex helper functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 30 Dec 2015 09:28:06 +0900
From:	Chanwoo Choi <cw00.choi@...sung.com>
To:	Charles Keepax <ckeepax@...nsource.wolfsonmicro.com>
Cc:	myungjoo.ham@...sung.com, linux-kernel@...r.kernel.org,
	patches@...nsource.wolfsonmicro.com
Subject: Re: [PATCH] extcon: arizona: Use DAPM mutex helper functions

On 2015년 12월 30일 01:32, Charles Keepax wrote:
> We should be using the helper functions to lock the DAPM mutex not
> accessing it directly. There are no ill effects of this as the moment
> but it is best practice, and the implementation could be changed in the
> future.
> 
> Signed-off-by: Charles Keepax <ckeepax@...nsource.wolfsonmicro.com>
> ---
>  drivers/extcon/extcon-arizona.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/extcon/extcon-arizona.c b/drivers/extcon/extcon-arizona.c
> index c121d01..1d8e0a5 100644
> --- a/drivers/extcon/extcon-arizona.c
> +++ b/drivers/extcon/extcon-arizona.c
> @@ -185,7 +185,7 @@ static void arizona_extcon_hp_clamp(struct arizona_extcon_info *info,
>  		break;
>  	};
>  
> -	mutex_lock(&arizona->dapm->card->dapm_mutex);
> +	snd_soc_dapm_mutex_lock(arizona->dapm);
>  
>  	arizona->hpdet_clamp = clamp;
>  
> @@ -227,7 +227,7 @@ static void arizona_extcon_hp_clamp(struct arizona_extcon_info *info,
>  				 ret);
>  	}
>  
> -	mutex_unlock(&arizona->dapm->card->dapm_mutex);
> +	snd_soc_dapm_mutex_unlock(arizona->dapm);
>  }
>  
>  static void arizona_extcon_set_mode(struct arizona_extcon_info *info, int mode)
> 

Looks good to me. Applied it.

Thanks,
Chanwoo Choi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/