linux-kernel - Re: [PATCH] scripts: recordmcount: fix incorrect use of sprintf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 4 Jan 2016 10:42:46 -0500
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Colin King <colin.king@...onical.com>
Cc:	Li Bin <huawei.libin@...wei.com>,
	Russell King <rmk+kernel@....linux.org.uk>,
	Will Deacon <will.deacon@....com>,
	linux-kernel@...r.kernel.org, Fengguang Wu <fengguang.wu@...el.com>
Subject: Re: [PATCH] scripts: recordmcount: fix incorrect use of sprintf

On Wed, 30 Dec 2015 23:06:41 +0000
Colin King <colin.king@...onical.com> wrote:

> From: Colin Ian King <colin.king@...onical.com>
> 
> Fix build warning:
> 
> scripts/recordmcount.c:589:4: warning: format not a string
> literal and no format arguments [-Wformat-security]
>     sprintf("%s: failed\n", file);
> 
> Fixes: a50bd43935586 ("ftrace/scripts: Have recordmcount copy the object file")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
>  scripts/recordmcount.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/recordmcount.c b/scripts/recordmcount.c
> index 301d70b..e1675927 100644
> --- a/scripts/recordmcount.c
> +++ b/scripts/recordmcount.c
> @@ -586,7 +586,7 @@ main(int argc, char *argv[])
>  			do_file(file);
>  			break;
>  		case SJ_FAIL:    /* error in do_file or below */
> -			sprintf("%s: failed\n", file);
> +			fprintf(stderr, "%s: failed\n", file);

Paper bag bug. I'm not sure how this passed my tests? My tests check
for warnings. And I even got a "BUILD SUCCESS" from Fengguang Wu's
kbuild test robot.

I'll apply it, test it, and push it out soon.

Thanks!

-- Steve


>  			++n_error;
>  			break;
>  		case SJ_SUCCEED:    /* premature success */

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/