linux-kernel - Re: [PATCH 0/5] usb-misc: cleanup sisusbvga

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 6 Jan 2016 16:30:05 +0100
From:	Peter Senna Tschudin <peter.senna@...labora.com>
To:	Joe Perches <joe@...ches.com>
Cc:	thomas@...ischhofer.net, gregkh@...uxfoundation.org,
	trivial@...nel.org, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/5] usb-misc: cleanup sisusbvga

On Tue, Jan 05, 2016 at 10:53:24AM -0800, Joe Perches wrote:
> On Tue, 2016-01-05 at 17:54 +0100, Peter Senna Tschudin wrote:
> []
> > Patch 1 is the biggest and fix only whitespace, tab and newline issues. I used
> > 
> > $ git diff -w --word-diff=porcelain drivers/usb/misc/sisusbvga/sisusb.c
> > 
> > to verify that this patch do not change any visible character. If the size of
> > this patch is a problem, please let me know in how many patches to split it.
> 
> Thanks.
> 
> Maybe for future series, but not one in particular unless
> you feel like respinning it:
> 
> As porcelain is meant for script consumption,  I think a good
> mechanism
> for human review is to separate patch 1 into 2 patches.
> 
> 1: Only horizontal line whitespace changes
>    git diff -w shouldn't show any changes and
>    git blame -w would not show any change either.
> 2: Only vertical line changes additions/reformatting
> 
> This makes it easy to use git diff -w on patch 1 and
> patch 2 can be more easily scanned visually.
This makes sense, the challenge is doing horizontal first, as making
vertical changes will probably require additional horizontal changes. Or
is it ok to fix horizontal issues caused by vertical changes in the
vertical changes patch? Is it reasonable to respin if other issues are
reported for this series?  Anyway I'll make the next series as you
suggest.

> 
> It's also nice to use objdiff and show no object changes.
Nice tool. I didn't know about it. Should I create a README file for the
scripts directory?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/