linux-kernel - RE: [PATCH V2 0/3] Change notes of V2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 7 Jan 2016 03:15:12 +0000
From:	"Yu, Xiangliang" <Xiangliang.Yu@....com>
To:	Allen Hubbe <Allen.Hubbe@....com>,
	"jdmason@...zu.us" <jdmason@...zu.us>,
	"dave.jiang@...el.com" <dave.jiang@...el.com>,
	"linux-ntb@...glegroups.com" <linux-ntb@...glegroups.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:	SPG_Linux_Kernel <SPG_Linux_Kernel@....com>
Subject: RE: [PATCH V2 0/3] Change notes of V2

> From: Xiangliang Yu <Xiangliang.Yu@....com>:
> > Main changes in V2:
> > 1. Fixed compiler warning;
> > 2. Add marcro argument of ndev in NTB_READ_REG/NTB_WRITE_REG; 3.
> Add
> > notes for flush and wakeup interfaces;
> >
> > Xiangliang Yu (3):
> >   NTB: Add AMD PCI-Express NTB driver
> >   NTB: Add AMD NTB support in Kconfig and Makefile
> >   NTB: Add flush_req and wakeup interface
> 
> Could you re-spin these patches as:
> 
> Patch 1:
> 	Only the parts of the driver that fit the current NTB APIs.
> 
> Patch 2:
> 	The new flush_req API, and the related code in the AMD driver.
> 
> Patch 3:
> 	The new wakeup API, and related code in the AMD driver.
> 
Ok.

> In particular, I think we need feedback on #3 from PCI and power
> management maintainers.
I don't get your concern.
I think we can add device attribute file to let application to trigger wakeup function, then NTB hardware will do the rest. NTB driver just need to implement suspend/resume interface of PCI PM.

Add one more thing, do you think NTB should support runtime power management?

> 
> When making #1, please make sure that the patch stands on its own, without
> any of the code related to #2 or #3 in #1.  Do put the makefile and kconfig
> changes in #1.
Ok.