linux-kernel - Re: [PATCH] drivers/usb: Skip auto handoff for TI and RENESAS usb controllers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 7 Jan 2016 09:29:57 -0800
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Babu Moger <babu.moger@...cle.com>
Cc:	mathias.nyman@...el.com, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers/usb: Skip auto handoff for TI and RENESAS usb
 controllers

On Thu, Jan 07, 2016 at 09:23:27AM -0800, Babu Moger wrote:
> I have never seen auto handoff working on TI and RENESAS cards.
> Eventually, we force handoff. This code forces the handoff
> unconditionally. It saves 5 seconds boot time for each card.
> 
> Signed-off-by: Babu Moger <babu.moger@...cle.com>
> ---
>  drivers/usb/host/pci-quirks.c |    7 +++++++
>  1 files changed, 7 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/usb/host/pci-quirks.c b/drivers/usb/host/pci-quirks.c
> index f940056..b7ee895 100644
> --- a/drivers/usb/host/pci-quirks.c
> +++ b/drivers/usb/host/pci-quirks.c
> @@ -1003,6 +1003,13 @@ static void quirk_usb_handoff_xhci(struct pci_dev *pdev)
>  		ext_cap_offset = xhci_find_next_cap_offset(base, ext_cap_offset);
>  	} while (1);
>  
> +	/* Auto handoff never worked for these devices. Force it and continue */
> +	if (pdev->vendor == PCI_VENDOR_ID_TI ||
> +			pdev->vendor == PCI_VENDOR_ID_RENESAS) {
> +		val  =  (val | XHCI_HC_OS_OWNED) & ~XHCI_HC_BIOS_OWNED;

odd spaces here, why this format?

And are you sure that all TI and Renesas host controllers have this
issue?  That's a very wide and broad test you are making here...

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/