linux-kernel - Re: [PATCH] acpi: avoid leaking format string into kobject name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 08 Jan 2016 01:44:33 +0100
From:	"Rafael J. Wysocki" <rjw@...ysocki.net>
To:	Kees Cook <keescook@...omium.org>
Cc:	Len Brown <lenb@...nel.org>, linux-acpi@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] acpi: avoid leaking format string into kobject name

On Thursday, January 07, 2016 11:24:29 AM Kees Cook wrote:
> The dn->name is expected to be used as a literal, so add the missing
> "%s".
> 
> Signed-off-by: Kees Cook <keescook@...omium.org>

Applied, thanks!

> ---
>  drivers/acpi/device_sysfs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/acpi/device_sysfs.c b/drivers/acpi/device_sysfs.c
> index 707cf6213bc2..b9afb47db7ed 100644
> --- a/drivers/acpi/device_sysfs.c
> +++ b/drivers/acpi/device_sysfs.c
> @@ -104,7 +104,7 @@ static void acpi_expose_nondev_subnodes(struct kobject *kobj,
>  
>  		init_completion(&dn->kobj_done);
>  		ret = kobject_init_and_add(&dn->kobj, &acpi_data_node_ktype,
> -					   kobj, dn->name);
> +					   kobj, "%s", dn->name);
>  		if (ret)
>  			acpi_handle_err(dn->handle, "Failed to expose (%d)\n", ret);
>  		else
> 

-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.