linux-kernel - Re: [PATCH v3] acpi, apei: add Boot Error Record Table (BERT) support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 8 Jan 2016 11:29:36 +0800
From:	Fu Wei <fu.wei@...aro.org>
To:	G Gregory <graeme.gregory@...aro.org>
Cc:	Huang Ying <ying.huang@...el.com>, Tony Luck <tony.luck@...el.com>,
	"Chen, Gong" <gong.chen@...el.com>,
	Tomasz Nowicki <tomasz.nowicki@...aro.org>,
	Tomasz Nowicki <tn@...ihalf.com>, tbaicar@...eaurora.org,
	rruigrok@...eaurora.org,
	"Abdulhamid, Harb" <harba@....qualcomm.com>,
	Al Stone <al.stone@...aro.org>,
	Hanjun Guo <hanjun.guo@...aro.org>,
	LKML <linux-kernel@...r.kernel.org>,
	"linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>,
	Linaro ACPI Mailman List <linaro-acpi@...ts.linaro.org>,
	Jon Masters <jcm@...hat.com>,
	Mark Rutland <mark.rutland@....com>,
	Catalin Marinas <catalin.marinas@....com>,
	Will Deacon <will.deacon@....com>,
	Rafael Wysocki <rjw@...ysocki.net>, bp <bp@...en8.de>,
	"matt.fleming" <matt.fleming@...el.com>,
	"Chen, Gong" <gong.chen@...ux.intel.com>
Subject: Re: [PATCH v3] acpi, apei: add Boot Error Record Table (BERT) support

Hi Graeme,

On 8 January 2016 at 00:22, G Gregory <graeme.gregory@...aro.org> wrote:
> On 7 January 2016 at 16:21, Fu Wei <fu.wei@...aro.org> wrote:
>> Hi Huang,
>>
>> On 7 January 2016 at 20:00, kbuild test robot <lkp@...el.com> wrote:
>>> Hi Huang,
>>>
>>> [auto build test WARNING on pm/linux-next]
>>> [also build test WARNING on v4.4-rc8 next-20160106]
>>> [if your patch is applied to the wrong git tree, please drop us a note to help improving the system]
>>>
>>> url:    https://github.com/0day-ci/linux/commits/fu-wei-linaro-org/acpi-apei-add-Boot-Error-Record-Table-BERT-support/20160107-193040
>>> base:   https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next
>>> config: x86_64-lkp (attached as .config)
>>> reproduce:
>>>         # save the attached .config to linux build tree
>>>         make ARCH=x86_64
>>>
>>> All warnings (new ones prefixed by >>):
>>>
>>>>> drivers/acpi/apei/bert.c:31:14: warning: extra tokens at end of #undef directive
>>>     #undef pr_fmt(fmt)
>>>                  ^
>>>
>>> vim +31 drivers/acpi/apei/bert.c
>>>
>>>     15   *
>>>     16   * For more information about BERT, please refer to ACPI Specification
>>>     17   * version 4.0, section 17.3.1
>>>     18   *
>>>     19   * This file is licensed under GPLv2.
>>>     20   *
>>>     21   */
>>>     22
>>>     23  #include <linux/kernel.h>
>>>     24  #include <linux/module.h>
>>>     25  #include <linux/init.h>
>>>     26  #include <linux/acpi.h>
>>>     27  #include <linux/io.h>
>>>     28
>>>     29  #include "apei-internal.h"
>>>     30
>>>   > 31  #undef pr_fmt(fmt)
>>
>> Do you have any idea?
>> I did not get warnings when I compiled this for arm64.
>> But without it, I got "redefined" warning.
>>
> Shouldn't it be just
>
> #undef pr_fmt

Thanks for pointing out this, yes, my bad!

fixed it !

>
> No arguments!
>
> Graeme
>
>>>     32  #define pr_fmt(fmt) "BERT: " fmt
>>>     33
>>>     34  static int bert_disable;
>>>     35
>>>     36  static void __init bert_print_all(struct acpi_bert_region *region,
>>>     37                                    unsigned int region_len)
>>>     38  {
>>>     39          /*
>>>
>>> ---
>>> 0-DAY kernel test infrastructure                Open Source Technology Center
>>> https://lists.01.org/pipermail/kbuild-all                   Intel Corporation
>>
>>
>>
>> --
>> Best regards,
>>
>> Fu Wei
>> Software Engineer
>> Red Hat Software (Beijing) Co.,Ltd.Shanghai Branch
>> Ph: +86 21 61221326(direct)
>> Ph: +86 186 2020 4684 (mobile)
>> Room 1512, Regus One Corporate Avenue,Level 15,
>> One Corporate Avenue,222 Hubin Road,Huangpu District,
>> Shanghai,China 200021



-- 
Best regards,

Fu Wei
Software Engineer
Red Hat Software (Beijing) Co.,Ltd.Shanghai Branch
Ph: +86 21 61221326(direct)
Ph: +86 186 2020 4684 (mobile)
Room 1512, Regus One Corporate Avenue,Level 15,
One Corporate Avenue,222 Hubin Road,Huangpu District,
Shanghai,China 200021