linux-kernel - Re: [PATCH 01/23] devicetree: bindings: hisi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 8 Jan 2016 15:34:37 +0000
From:	John Garry <john.garry@...wei.com>
To:	Mark Rutland <mark.rutland@....com>
CC:	<JBottomley@...n.com>, <martin.petersen@...cle.com>,
	<robh+dt@...nel.org>, <pawel.moll@....com>,
	<ijc+devicetree@...lion.org.uk>, <galak@...eaurora.org>,
	<linuxarm@...wei.com>, <zhangfei.gao@...aro.org>,
	<xuwei5@...ilicon.com>, <john.garry2@...l.dcu.ie>,
	<linux-scsi@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<arnd@...db.de>, <devicetree@...r.kernel.org>
Subject: Re: [PATCH 01/23] devicetree: bindings: hisi_sas: add v2 HW bindings


>>>> +Optional main node properties:
>>>> + - am-max-trans : limit controller for am max transmissions
>>>
>>> Is this a boolean? Number?
>>>
>>
>> This is a boolean. It is for dealing with a quirk in the chipset: an
>> instance of the controller in the hip06 chipset requires registers
>> set with a different init value.
>
> Ok. I think the property at needs a better description for that.
>
> It's not clear to me how "limit controller for am max transmissions"
> maps to writing a specific value to some registers, but I don't know
> much about SAS.
>
> Is this some well-known thing, or values specific to hip06?
>
> Thanks,
> Mark.
>

This is a specific issue for hip06 chipset. There is a bug in the HW on 
hip06 where controller #1 has to set to 2 registers to non-default 
values to limit "am-max-transmissions". This would not be a common 
SAS/SCSI controller property and is specific to our HW.

Thanks,
John