linux-kernel - Re: [PATCH 2/2] mmc: atmel: get rid of struct mci_dma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 09 Jan 2016 12:13:03 +0000
From:	Måns Rullgård <mans@...sr.com>
To:	Andy Shevchenko <andy.shevchenko@...il.com>
Cc:	Haavard Skinnemoen <hskinnemoen@...il.com>,
	Hans-Christian Egtvedt <egtvedt@...fundet.no>,
	Ludovic Desroches <ludovic.desroches@...el.com>,
	Ulf Hansson <ulf.hansson@...aro.org>,
	Arnd Bergmann <arnd@...db.de>,
	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
	"linux-kernel\@vger.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-mmc\@vger.kernel.org" <linux-mmc@...r.kernel.org>
Subject: Re: [PATCH 2/2] mmc: atmel: get rid of struct mci_dma_data

Andy Shevchenko <andy.shevchenko@...il.com> writes:

> On Sat, Jan 9, 2016 at 3:22 AM, Mans Rullgard <mans@...sr.com> wrote:
>> As struct mci_dma_data is now only used by AVR32, it is nothing but
>> pointless indirection.  Replace it with struct dw_dma_slave in the
>> AVR32 platform code and with a void pointer elsewhere.
>>
>> Signed-off-by: Mans Rullgard <mans@...sr.com>
>
>> @@ -1376,15 +1375,15 @@ at32_add_device_mci(unsigned int id, struct mci_platform_data *data)
>>                                 ARRAY_SIZE(atmel_mci0_resource)))
>>                 goto fail;
>>
>> -       slave = kzalloc(sizeof(struct mci_dma_data), GFP_KERNEL);
>> +       slave = kzalloc(sizeof(*slave), GFP_KERNEL);
>>         if (!slave)
>>                 goto fail;
>>
>> -       slave->sdata.dma_dev = &dw_dmac0_device.dev;
>> -       slave->sdata.src_id = 0;
>> -       slave->sdata.dst_id = 1;
>> -       slave->sdata.m_master = 1;
>> -       slave->sdata.p_master = 0;
>
> Seems you based this on top of our non-submitted yet patches.

You're right.  I didn't realise this file had been touched by those
patches, and I didn't read the code all that carefully when making this
change.

>> +       slave->dma_dev = &dw_dmac0_device.dev;
>> +       slave->src_id = 0;
>> +       slave->dst_id = 1;
>> +       slave->m_master = 1;
>> +       slave->p_master = 0;
>
> -- 
> With Best Regards,
> Andy Shevchenko

-- 
Måns Rullgård