linux-kernel - [PATCH -next] tty/serial: atmel: Include module.h to fix build failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Sat,  9 Jan 2016 10:15:35 -0800
From:	Guenter Roeck <linux@...ck-us.net>
To:	Nicolas Ferre <nicolas.ferre@...el.com>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org,
	Guenter Roeck <linux@...ck-us.net>,
	Paul Gortmaker <paul.gortmaker@...driver.com>
Subject: [PATCH -next] tty/serial: atmel: Include module.h to fix build failure

If serial/atmel_serial.c is compiled with devicetree enabled, the
following build error is observed.

drivers/tty/serial/atmel_serial.c:192:1: warning:
	data definition has no type or storage class
drivers/tty/serial/atmel_serial.c:192:1: error:
	type defaults to 'int' in declaration of 'MODULE_DEVICE_TABLE'
drivers/tty/serial/atmel_serial.c:192:1: warning:
	parameter names (without types) in function declaration

MODULE_DEVICE_TABLE is used to specify devicetree compatibilities.

Fixes: c39dfebc7798 ("drivers/tty/serial: make serial/atmel_serial.c explicitly non-modular")
Cc: Paul Gortmaker <paul.gortmaker@...driver.com>
Signed-off-by: Guenter Roeck <linux@...ck-us.net>
---
 drivers/tty/serial/atmel_serial.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/tty/serial/atmel_serial.c b/drivers/tty/serial/atmel_serial.c
index 50e785a0ea73..71c385b09db8 100644
--- a/drivers/tty/serial/atmel_serial.c
+++ b/drivers/tty/serial/atmel_serial.c
@@ -22,6 +22,7 @@
  * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
  *
  */
+#include <linux/module.h>
 #include <linux/tty.h>
 #include <linux/ioport.h>
 #include <linux/slab.h>
-- 
2.1.4