linux-kernel - Re: [PATCH -next] net: ti: cpmac: Fix build error due to missed API change

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 9 Jan 2016 22:23:47 +0100
From:	Andrew Lunn <andrew@...n.ch>
To:	Guenter Roeck <linux@...ck-us.net>
Cc:	Florian Fainelli <florian@...nwrt.org>, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] net: ti: cpmac: Fix build error due to missed API
 change

On Sat, Jan 09, 2016 at 01:19:39PM -0800, Guenter Roeck wrote:
> Commit 7f854420fbfe ("phy: Add API for {un}registering an mdio device to
> a bus") introduces an API to access mii_bus structures, but missed to
> update the TI cpamc driver. This results in the following error message.
> 
> drivers/net/ethernet/ti/cpmac.c: In function 'cpmac_probe':
> drivers/net/ethernet/ti/cpmac.c:1119:18: error:
> 	'struct mii_bus' has no member named 'phy_map'
> 
> Fixes: 7f854420fbfe ("phy: Add API for {un}registering an mdio device to a bus")
> Cc: Andrew Lunn <andrew@...n.ch>
> Signed-off-by: Guenter Roeck <linux@...ck-us.net>

Acked-by: Andrew Lunn <andrew@...n.ch>

Thanks
	Andrew

> ---
>  drivers/net/ethernet/ti/cpmac.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/ti/cpmac.c b/drivers/net/ethernet/ti/cpmac.c
> index 0b483301767d..7eef45e6d70a 100644
> --- a/drivers/net/ethernet/ti/cpmac.c
> +++ b/drivers/net/ethernet/ti/cpmac.c
> @@ -1116,7 +1116,7 @@ static int cpmac_probe(struct platform_device *pdev)
>  		for (phy_id = 0; phy_id < PHY_MAX_ADDR; phy_id++) {
>  			if (!(pdata->phy_mask & (1 << phy_id)))
>  				continue;
> -			if (!cpmac_mii->phy_map[phy_id])
> +			if (!mdiobus_get_phy(cpmac_mii, phy_id))
>  				continue;
>  			strncpy(mdio_bus_id, cpmac_mii->id, MII_BUS_ID_SIZE);
>  			break;
> -- 
> 2.1.4
>