linux-kernel - Re: [PATCH] dt-bindings: Fix the external clock name for the RK3036 EMAC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 10 Jan 2016 18:36:12 +0800
From:	Xing Zheng <zhengxing@...k-chips.com>
To:	Heiko Stuebner <heiko@...ech.de>
Cc:	linux-rockchip@...ts.infradead.org, keescook@...gle.com,
	leozwang@...gle.com, Rob Herring <robh+dt@...nel.org>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>, devicetree@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	xing.zheng@...k-chips.com
Subject: Re: [PATCH] dt-bindings: Fix the external clock name for the RK3036 EMAC

Hi Heiko,

> 在 2016年1月10日，18:29，Xing Zheng <zhengxing@...k-chips.com> 写道：
> 
> 
> Hi Heiko,
> 
>> 在 2016年1月10日，17:59，Heiko Stuebner <heiko@...ech.de> 写道：
>> 
>> Hi Xing,
>> 
>> Am Sonntag, 10. Januar 2016, 15:22:37 schrieb Xing Zheng:
>>> Because the RK3036 doesn't support EMAC, and only support the RMII mode
>>> in the EMAC IP, we refer to the TRM CRU and update the new external
>>> clock name for EMAC.
>>> 
>>> Signed-off-by: Xing Zheng <zhengxing@...k-chips.com>
>> 
>> as I said in the other mail, I already fixed the original patch myself :-)
>> So I'm just going to drop this one.
>> 
>> 
>> Heiko
>> 
>> https://git.kernel.org/cgit/linux/kernel/git/mmind/linux-rockchip.git/commit/?h=v4.5-clk/fixes&id=88807906af108a8384d77ad9cfb9421f164ea931
> I am sorry to misunderstand.
> 
> OK, thank you for your help.  :)

Your patch is:
- - "ext_gmac" - external GMAC clock - optional
+ - "rmii_clkin" - external GMAC clock - optional

I think that these should be like this:
- - "ext_gmac" - external GMAC clock - optional
+ - "rmii_clkin" - external EMAC clock - optional

Thanks. :)