linux-kernel - Re: [RFC PATCH 2/4] workqueue: free the allocated memory resource when wq_numa

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 11 Jan 2016 12:26:17 +0800
From:	wanghaibin <wanghaibin.wang@...wei.com>
To:	Tejun Heo <tj@...nel.org>
CC:	<linux-kernel@...r.kernel.org>, <jiangshanlai@...il.com>,
	<peter.huangpeng@...wei.com>
Subject: Re: [RFC PATCH 2/4] workqueue: free the allocated memory resource
 when wq_numa_init failed.

On 2016/1/7 23:50, Tejun Heo wrote:

> On Thu, Jan 07, 2016 at 08:38:57PM +0800, wanghaibin wrote:
>> Before the return that wq_numa_init failed, it will be bettet to free
>> the numa node table to avoid the memory leaks.
> 

OK, I just expect that it can free the memory in all exception cases!

> That's a WARN_ON condition which should never happen.  The system is
> already pretty messed up and just limping along.  It really doesn't
> matter whether some memory is cleaned up or not.  Let's keep it
> simple.

OK, get it !


> 
> Thanks.
>