linux-kernel - Re: [PATCH v3 1/2] PCI: generic: Refactor code to enable reuse by other drivers.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 12 Jan 2016 17:59:58 +0000
From:	Will Deacon <will.deacon@....com>
To:	David Daney <ddaney.cavm@...il.com>
Cc:	Bjorn Helgaas <bhelgaas@...gle.com>, linux-pci@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org,
	Rob Herring <robh+dt@...nel.org>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, David Daney <david.daney@...ium.com>
Subject: Re: [PATCH v3 1/2] PCI: generic: Refactor code to enable reuse by
 other drivers.

On Fri, Jan 08, 2016 at 03:59:12PM -0800, David Daney wrote:
> From: David Daney <david.daney@...ium.com>
> 
> No change in functionality.
> 
> Move structure definitions into a separate header file.  Move common
> code to new file with Kconfig machinery to build it.  Split probe
> function in to two parts:
> 
>    - a small driver specific probe function (gen_pci_probe)
> 
>    - a common probe that can be used by other drivers
>      (pci_host_common_probe)
> 
> Signed-off-by: David Daney <david.daney@...ium.com>
> ---
>  MAINTAINERS                         |   1 +
>  drivers/pci/host/Kconfig            |   4 +
>  drivers/pci/host/Makefile           |   1 +
>  drivers/pci/host/pci-host-common.c  | 194 ++++++++++++++++++++++++++++++++++++
>  drivers/pci/host/pci-host-common.h  |  56 +++++++++++
>  drivers/pci/host/pci-host-generic.c | 190 +----------------------------------
>  6 files changed, 260 insertions(+), 186 deletions(-)
>  create mode 100644 drivers/pci/host/pci-host-common.c
>  create mode 100644 drivers/pci/host/pci-host-common.h

Looks fine to me:

  Acked-by: Will Deacon <will.deacon@....com>

Will