linux-kernel - Re: lib: sw842: select crc32

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 13 Jan 2016 22:36:57 -0500
From:	Dan Streetman <ddstreet@...e.org>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	Herbert Xu <herbert@...dor.apana.org.au>,
	Linux Crypto Mailing List <linux-crypto@...r.kernel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: lib: sw842: select crc32

On Wed, Jan 13, 2016 at 5:24 PM, Arnd Bergmann <arnd@...db.de> wrote:
> The sw842 library code was merged in linux-4.1 and causes a very rare randconfig
> failure when CONFIG_CRC32 is not set:
>
>     lib/built-in.o: In function `sw842_compress':
>     oid_registry.c:(.text+0x12ddc): undefined reference to `crc32_be'
>     lib/built-in.o: In function `sw842_decompress':
>     oid_registry.c:(.text+0x137e4): undefined reference to `crc32_be'
>
> This adds an explict 'select CRC32' statement, similar to what the other users
> of the crc32 code have. In practice, CRC32 is always enabled anyway because
> over 100 other symbols select it.
>
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> Fixes: 2da572c959dd ("lib: add software 842 compression/decompression")

Acked-by: Dan Streetman <ddstreet@...e.org>

>
> diff --git a/lib/Kconfig b/lib/Kconfig
> index 1ce5af9cc418..ee38a3fd2814 100644
> --- a/lib/Kconfig
> +++ b/lib/Kconfig
> @@ -217,9 +217,11 @@ config RANDOM32_SELFTEST
>  # compression support is select'ed if needed
>  #
>  config 842_COMPRESS
> +       select CRC32
>         tristate
>
>  config 842_DECOMPRESS
> +       select CRC32
>         tristate
>
>  config ZLIB_INFLATE
>